Repository navigation
Fix /webSearch responses and prepare v1.0.0-beta - #144
Merged
Merged
Conversation
jdaigneau5
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/webSearchresponses whencve-coreomits optional result metadata.1.0.0-beta.Why This Change Is Needed
cve-corereturns successfulCveResultobjects witherrorsomitted. The Search API response validator requirederrorsto be an array, so valid OpenSearch results were rejected and returned as sanitized HTTP 502 responses. The existing test fixtures always suppliederrors: [], which did not represent the realcve-coresuccess shape and masked the regression.Changes
notesanderrorsmetadata to empty arrays while validating successful/webSearchresponsescontrollers/searchController.jscve-coreresult shape without weakening malformed-response checksCveResultmetadata and add malformed-metadata regression coveragecontrollers/searchController.test.jsroutes/search.integration.test.jsnotesanderrorsarrays1.0.0-betapackage.json,package-lock.json,api-docs/openapi.jsonValidation
/webSearchrequests succeeded for default, CVE ID, and relevancy sorting.git diff --checkpassed for the changed files.