Skip to content

Record the adapters as 1.3.0, which is what PyPI has served since 09-15 - #224

Merged
rohanrkamath merged 1 commit into
mainfrom
published-record-1-3-0
Sep 15, 2026
Merged

rohanrkamath merged 1 commit into
mainfrom
published-record-1-3-0

Conversation

@arpanghoshal

@arpanghoshal arpanghoshal commented Sep 15, 2026

Copy link
Copy Markdown
Member

Independent of #223 and #48; it blocks neither, and neither blocks it.

adapters/PUBLISHED.toml records what pip download actually gets. It said 1.2.0 / <0.12. Both adapters were tagged and uploaded at 1.3.0 / <0.13 on 2026-09-15:

ctrlrun-langgraph      1.3.0  ctrlrun<0.13,>=0.5   uploaded 2026-09-15T01:26:30
ctrlrun-openai-agents  1.3.0  ctrlrun<0.13,>=0.5   uploaded 2026-09-15T01:26:37

That is the fourth release running this file has gone stale, in the file whose header documents the other three.

It was not bookkeeping, the guard was off

test_a_widened_kernel_range_is_not_shipped_without_a_new_version returns early when the tree and the record disagree and the tree carries the higher version, because that is exactly the shape of a correct pending release. A stale record therefore looks like a pending release forever, and the check stops checking.

Probed both ways on this branch, with adapters/langgraph widened to <0.14 and its version deliberately left alone, which is the precise defect the test exists to catch:

record result
1.2.0, as it was 2 passed, the widening ships unnoticed
1.3.0, as it is here 1 failed, assert 1.3.0 != 1.3.0

RECORDED gains the 1.3.0 row so that range is frozen as the historical fact it is.

What would end this, and why it is not here

The header now carries the fourth recurrence and names the fix: publish.yml refusing to upload an adapter whose version and kernel range this file does not already record. That makes the record a precondition of the upload rather than a chore after it, and the upload being the last thing that happens is precisely why the chore keeps being skipped.

I did not build it. It reverses the rule the file currently states in its own header, and it touches the release path, so it is a decision rather than a cleanup. Say the word and it is a small change.

Summary by CodeRabbit

  • Documentation

    • Updated publication records for the LangGraph and OpenAI Agents adapters to version 1.3.0.
    • Clarified that both adapters support kernel versions 0.5 through below 0.13.
  • Tests

    • Updated packaging validation to recognize the published 1.3.0 adapter records and their supported kernel range.

`adapters/PUBLISHED.toml` said 1.2.0 / `<0.12`. Both adapters were tagged and uploaded
at 1.3.0 / `<0.13` on 2026-09-15 and nobody came back to the record, which is the fourth
release running that this file has gone stale, in the file that documents the other
three.

**A stale record does not merely misinform: it switches the guard off.**
`test_a_widened_kernel_range_is_not_shipped_without_a_new_version` returns early when
the tree and the record disagree *and* the tree's version is higher, because that is
indistinguishable from a correct pending release. Probed both ways on this branch, with
the tree widened to `<0.14` and no version bump, which is the exact defect the test
exists to catch:

    record 1.2.0 (stale)   2 passed        <- the widening ships unnoticed
    record 1.3.0 (fixed)   1 failed        <- assert '1.3.0' != '1.3.0'

So this is not bookkeeping. It is the check coming back on.

`RECORDED` gains the 1.3.0 row so that range is frozen as the historical fact it is.

The header now carries the fourth recurrence and says what would actually end it:
`publish.yml` refusing to upload an adapter whose version and range this file does not
already record, which makes the record a precondition of the upload rather than a chore
after it. Not built here. It reverses the rule the file currently states and belongs in
its own change.

Signed-off-by: arpan <contact@arpanghoshal.com>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 31ec3168-f6c7-4684-a78e-cbff97cf5e58

📥 Commits

Reviewing files that changed from the base of the PR and between abebf27 and f982470.

📒 Files selected for processing (2)
  • adapters/PUBLISHED.toml
  • tests/test_packaging.py

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The adapter publication records now show version 1.3.0 and kernel range >=0.5,<0.13. Packaging test data records the same ranges. The publication file documents the stale record incident.

Changes

Adapter publication records

Layer / File(s) Summary
Publication record and test synchronization
adapters/PUBLISHED.toml, tests/test_packaging.py
The langgraph and openai-agents records now use version 1.3.0 and kernel range >=0.5,<0.13. RECORDED includes matching historical entries. The publication file documents the stale publication incident.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f9824

The adapter publication metadata now matches the versions and kernel ranges served on PyPI, with no unresolved merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: recording both adapters as version 1.3.0 to match the versions served on PyPI since September 15, 2026.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch published-record-1-3-0

Comment @coderabbitai help to get the list of available commands.

@rohanrkamath
rohanrkamath merged commit 489eb9d into main Sep 15, 2026
16 checks passed
@rohanrkamath
rohanrkamath deleted the published-record-1-3-0 branch September 15, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants