debug

Author: valkyrienyanko

Scripts/Netcode/Common/CPacketPlayerPosition.cs

@@ -1,6 +1,7 @@
 using Godot;
 using GodotModules.Netcode.Server;
 using System;
+using System.Linq;
 
 namespace GodotModules.Netcode 
 {
@@ -24,6 +25,13 @@ public override void Read(PacketReader reader)
         public override void Handle(ENet.Peer peer)
         {
             GameServer.Players[peer.ID].Position = Position;
+
+            foreach (var pair in GameServer.Players)
+            {
+                GameServer.Send(ServerPacketOpcode.PlayerPositions, new SPacketPlayerPositions {
+                    PlayerPositions = GameServer.Players.Where(x => x.Key != pair.Key).ToDictionary(x => x.Key, x => x.Value.Position)
+                }, GameServer.Peers[pair.Key]);
+            }
         }
     }
 }

Scripts/Netcode/Server/ENetServer.cs

@@ -130,7 +130,15 @@ public async Task ENetThreadWorker(ushort port, int maxClients)
                             }
 
                             var handlePacket = HandlePacket[opcode];
-                            handlePacket.Read(packetReader);
+                            try
+                            {
+                                handlePacket.Read(packetReader);
+                            }
+                            catch (System.IO.EndOfStreamException)
+                            {
+                                Utils.LogErr($"[Server]: Received malformed opcode: {opcode} (Ignoring)");
+                                break;
+                            }
                             handlePacket.Handle(netEvent.Peer);
 
                             packetReader.Dispose();

Scripts/Netcode/Server/GameServer.cs

@@ -19,19 +19,19 @@ public GameServer()
         {
             Players = new Dictionary<uint, DataPlayer>();
 
-            EmitClientPositions = new Timer(200);
+            EmitClientPositions = new Timer(1000);
             EmitClientPositions.Elapsed += EmitClientPositionsCallback;
             EmitClientPositions.AutoReset = true;
         }
 
         public void EmitClientPositionsCallback(System.Object source, ElapsedEventArgs args)
         {
-            foreach (var pair in Players)
+            /*foreach (var pair in GameServer.Players)
             {
-                Send(ServerPacketOpcode.PlayerPositions, new SPacketPlayerPositions {
-                    PlayerPositions = Players.Where(x => x.Key != pair.Key).ToDictionary(x => x.Key, x => x.Value.Position)
-                }, Peers[pair.Key]);
-            }
+                GameServer.Send(ServerPacketOpcode.PlayerPositions, new SPacketPlayerPositions {
+                    PlayerPositions = GameServer.Players.Where(x => x.Key != pair.Key).ToDictionary(x => x.Key, x => x.Value.Position)
+                }, GameServer.Peers[pair.Key]);
+            }*/
         }
 
         protected override void Connect(Event netEvent)

Scripts/Scenes/Game/ClientPlayer.cs

@@ -16,7 +16,7 @@ public class ClientPlayer : OtherPlayer
         private Label LabelPosition { get; set; }
 
         private float Speed = 250f;
-        private static Timer EmitPosition { get; set; }
+        public static Timer EmitPosition { get; set; }
 
         public override void _Ready()
         {
@@ -26,7 +26,7 @@ public override void _Ready()
 
             if (GameClient.Running)
             {
-                EmitPosition = new Timer(200);
+                EmitPosition = new Timer(1000);
                 EmitPosition.Elapsed += EmitPositionCallback;
                 EmitPosition.AutoReset = true;
                 EmitPosition.Enabled = true;

Scripts/Scenes/Main/NetworkManager.cs

@@ -8,6 +8,7 @@
 using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
+using Game;
 
 namespace GodotModules
 {
@@ -46,7 +47,15 @@ public override void _Process(float delta)
                         }
 
                         var handlePacket = ENetClient.HandlePacket[opcode];
-                        handlePacket.Read(packetReader);
+                        try 
+                        {
+                            handlePacket.Read(packetReader);
+                        }
+                        catch (System.IO.EndOfStreamException)
+                        {
+                            Utils.LogErr($"[Client]: Received malformed opcode: {opcode} (Ignoring)");
+                            break;
+                        }
                         handlePacket.Handle();
 
                         packetReader.Dispose();
@@ -115,6 +124,9 @@ private static async Task ExitCleanup()
             if (ENetServer.CancelTokenSource != null)
                 ENetServer.CancelTokenSource.Dispose();
 
+            if (ClientPlayer.EmitPosition != null)
+                ClientPlayer.EmitPosition.Dispose();
+
             Instance.GetTree().Quit();
         }