PlayerPosition packet

Author: valkyrienyanko

Scripts/Netcode/Client/ENetClient.cs

@@ -91,10 +91,10 @@ private async Task ENetThreadWorker(string ip, ushort port)
                     while (Outgoing.TryRemove(OutgoingId, out ClientPacket clientPacket))
                     {
                         OutgoingId--;
-                        //Log("Sent packet: " + (ClientPacketOpcode)clientPacket.Opcode);
                         byte channelID = 0; // The channel all networking traffic will be going through
                         var packet = default(Packet);
                         packet.Create(clientPacket.Data, clientPacket.PacketFlags);
+                        //Log("Sent packet: " + (ClientPacketOpcode)clientPacket.Opcode);
                         peer.Send(channelID, ref packet);
                     }
 

Scripts/Netcode/Common/CPacketPlayerPosition.cs

@@ -0,0 +1,29 @@
+using Godot;
+using GodotModules.Netcode.Server;
+using System;
+
+namespace GodotModules.Netcode 
+{
+    public class CPacketPlayerPosition : APacketClient
+    {
+        public Vector2 Position { get; set; }
+
+        public override void Write(PacketWriter writer)
+        {
+            writer.Write((float)Math.Round(Position.x, 1));
+            writer.Write((float)Math.Round(Position.y, 1));
+        }
+
+        public override void Read(PacketReader reader)
+        {
+            var pos = new Vector2();
+            pos.x = reader.ReadFloat();
+            pos.y = reader.ReadFloat();
+        }
+
+        public override void Handle(ENet.Peer peer)
+        {
+            GameServer.Players[peer.ID].Position = Position;
+        }
+    }
+}

Scripts/Netcode/Common/_Opcodes.cs

@@ -8,7 +8,8 @@ public enum ClientPacketOpcode
         LobbyChatMessage,
         LobbyReady,
         LobbyCountdownChange,
-        LobbyGameStart
+        LobbyGameStart,
+        PlayerPosition
     }
 
     // Sent to Game Client

Scripts/Netcode/Server/ENetServer.cs

@@ -123,6 +123,12 @@ public async Task ENetThreadWorker(ushort port, int maxClients)
 
                             //Log($"Received packet: {opcode}");
 
+                            if (!HandlePacket.ContainsKey(opcode))
+                            {
+                                Utils.LogErr($"[Server]: Received malformed opcode: {opcode} (Ignoring)");
+                                break;
+                            }
+
                             var handlePacket = HandlePacket[opcode];
                             handlePacket.Read(packetReader);
                             handlePacket.Handle(netEvent.Peer);

Scripts/Netcode/Server/GameServer.cs

@@ -26,11 +26,12 @@ public GameServer()
 
         public void EmitClientPositionsCallback(System.Object source, ElapsedEventArgs args)
         {
-            var playerPositions = Players.ToDictionary(x => x.Key, x => x.Value.Position);
-
-            SendToAllPlayers(ServerPacketOpcode.PlayerPositions, new SPacketPlayerPositions {
-                PlayerPositions = playerPositions
-            }, PacketFlags.Reliable);
+            foreach (var pair in Players)
+            {
+                Send(ServerPacketOpcode.PlayerPositions, new SPacketPlayerPositions {
+                    PlayerPositions = Players.Where(x => x.Key != pair.Key).ToDictionary(x => x.Key, x => x.Value.Position)
+                }, Peers[pair.Key]);
+            }
         }
 
         protected override void Connect(Event netEvent)

Scripts/Scenes/Game/ClientPlayer.cs

@@ -16,7 +16,7 @@ public class ClientPlayer : OtherPlayer
         private Label LabelPosition { get; set; }
 
         private float Speed = 250f;
-        private Timer EmitPosition { get; set; }
+        private static Timer EmitPosition { get; set; }
 
         public override void _Ready()
         {
@@ -35,7 +35,9 @@ public override void _Ready()
 
         public async void EmitPositionCallback(System.Object source, ElapsedEventArgs args)
         {
-            
+            await GameClient.Send(ClientPacketOpcode.PlayerPosition, new CPacketPlayerPosition {
+                Position = Position
+            });
         }
 
         public override void _PhysicsProcess(float delta)

Scripts/Scenes/Main/NetworkManager.cs

@@ -37,11 +37,11 @@ public override void _Process(float delta)
                         var packetReader = (PacketReader)cmd.Data;
                         var opcode = (ServerPacketOpcode)packetReader.ReadByte();
 
-                        //Utils.Log($"[Client]: Received {opcode}");
+                        Utils.Log($"[Client]: Received {opcode}");
 
                         if (!ENetClient.HandlePacket.ContainsKey(opcode))
                         {
-                            Utils.LogErr($"Received malformed opcode: {opcode} (Ignoring)");
+                            Utils.LogErr($"[Client]: Received malformed opcode: {opcode} (Ignoring)");
                             break;
                         }