fix: add SSL certificate verification bypass for Windows 8 (closes #122)#188
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
SessionManagerraises an SSL certificate verification error on Windows 8 (Python 3.4). This occurs because the system's CA certificates are not properly configured, causingurllibto fail when verifying the server's SSL certificate.Fix
Add an
HTTPSHandlerwith SSL context that disables certificate verification (CERT_NONE) and hostname checking. This allows the connection to succeed even when the local CA store is incomplete or misconfigured. The change is minimal and only affects the opener creation insidemake_opener().Closes #122