Create MSYS2.yaml and fix some issues on MSYS2. - #905
Conversation
Add MSYS2 building action to check building issues on MSYS2. Fix some "error=char-subscripts" for isdigit and isspace functions by adding explicit cast to int, which is required by C99 standard and later.
|
Hello @pffang please answer why we set baudrate to unused? I believe it use in switch case block? |
You can check the macro detection inside the speed_t dlt_convert_serial_speed(int baudrate) function. MSYS will define the _CYGWIN macro, so it will go to the #else branch, and this branch doesn't use the baudrate parameter. |
|
@pffang This PR somehow block gtest dlt user from finishing, please check the touching in dlt common to see if the root cause from there |
That's strange. My changes only adapt to the strict grammar checking in the newer compiler, don't include any logic modification. |
minminlittleshrimp
left a comment
minminlittleshrimp
left a comment
There was a problem hiding this comment.
Look good to me
|
Hi @santhoshsivanhere |
2 participants
Add MSYS2 building action to check building issues on MSYS2.
Fix some "error=char-subscripts" for isdigit and isspace functions by adding explicit cast to int,
which is required by C99 standard and later.