Skip to content

[Draft] daemon: unix socket checking before creating new - #647

Open
minminlittleshrimp wants to merge 1 commit into
masterfrom
dev_fix_unix_socket_spamming
Open

[Draft] daemon: unix socket checking before creating new#647
minminlittleshrimp wants to merge 1 commit into
masterfrom
dev_fix_unix_socket_spamming

Conversation

@minminlittleshrimp

@minminlittleshrimp minminlittleshrimp commented Jun 27, 2024

Copy link
Copy Markdown
Collaborator
  • unix socket spamming removed

Comment thread src/daemon/dlt_daemon_unix_socket.c Fixed
@minminlittleshrimp
minminlittleshrimp force-pushed the dev_fix_unix_socket_spamming branch from b1b757d to 0c44b2f Compare June 27, 2024 10:34
Comment thread CMakeLists.txt Outdated
+ unix socket spamming removed

Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>
@minminlittleshrimp
minminlittleshrimp force-pushed the dev_fix_unix_socket_spamming branch from 0c44b2f to a01d5e9 Compare December 30, 2024 04:37
@minminlittleshrimp

minminlittleshrimp commented Dec 30, 2024

Copy link
Copy Markdown
Collaborator Author

With fix:

[*]─[Dr.Mint@local_machine]─[~/work/github/dlt-daemon]
 (dev_fix_unix_socket_spamming)
└──> dlt-daemon
[ 3131.055453]~DLT~2498218~NOTICE   ~Starting DLT Daemon; DLT Package Version: 2.18.10 STABLE, Package Revision: v2.18.10_47_ga01d5e9, build on Dec 30 2024 11:37:44
-SYSTEMD -SYSTEMD_WATCHDOG -TEST -SHM

[ 3131.055554]~DLT~2498218~INFO     ~FIFO size: 65536
[ 3131.055564]~DLT~2498218~WARNING  ~Unable to set send timeout Socket operation on non-socket.
[ 3131.055566]~DLT~2498218~INFO     ~Activate connection type: 5
[ 3131.055577]~DLT~2498218~INFO     ~dlt_daemon_socket_open: Socket created
[ 3131.055586]~DLT~2498218~INFO     ~dlt_daemon_socket_open: Listening on ip 0.0.0.0 and port: 3490
[ 3131.055589]~DLT~2498218~INFO     ~dlt_daemon_socket_open: Socket send queue size: 16384
[ 3131.055596]~DLT~2498218~INFO     ~Activate connection type: 1
[ 3131.055621]~DLT~2498218~INFO     ~Activate connection type: 9
[ 3131.055632]~DLT~2498218~INFO     ~Cannot open configuration file: /tmp/dlt-runtime.cfg
[ 3131.055634]~DLT~2498218~INFO     ~Ringbuffer configuration: 500000/10000000/500000
[ 3131.055763]~DLT~2498218~NOTICE   ~Failed to open ECU Software version file.
[ 3131.055775]~DLT~2498218~WARNING  ~Unable to set send timeout Socket operation on non-socket.
[ 3131.055776]~DLT~2498218~INFO     ~Activate connection type: 6
[ 3131.055780]~DLT~2498218~INFO     ~Switched to buffer state for socket connections.
[ 3131.055788]~DLT~2498218~WARNING  ~dlt_daemon_applications_load: cannot open file /tmp/dlt-runtime-application.cfg: No such file or directory

Without fix:

[*]─[Dr.Mint@local_machine]─[~/work/github/dlt-daemon]
 (dev_fix_unix_socket_spamming)
└──> dlt-daemon
[ 3185.043570]~DLT~2920315~NOTICE   ~Starting DLT Daemon; DLT Package Version: 2.18.10 STABLE, Package Revision: v2.18.10_46_g8fc4e8e, build on Dec 30 2024 11:38:52
-SYSTEMD -SYSTEMD_WATCHDOG -TEST -SHM

[ 3185.043641]~DLT~2920315~INFO     ~FIFO size: 65536
[ 3185.043654]~DLT~2920315~WARNING  ~Unable to set send timeout Socket operation on non-socket.
[ 3185.043657]~DLT~2920315~INFO     ~Activate connection type: 5
[ 3185.043672]~DLT~2920315~INFO     ~dlt_daemon_socket_open: Socket created
[ 3185.043683]~DLT~2920315~INFO     ~dlt_daemon_socket_open: Listening on ip 0.0.0.0 and port: 3490
[ 3185.043687]~DLT~2920315~INFO     ~dlt_daemon_socket_open: Socket send queue size: 16384
[ 3185.043700]~DLT~2920315~INFO     ~Activate connection type: 1
[ 3185.043711]~DLT~2920315~WARNING  ~dlt_daemon_unix_socket_open: unlink() failed: No such file or directory
--> When initializing, there should not be a check here
[ 3185.043735]~DLT~2920315~INFO     ~Activate connection type: 9
[ 3185.043745]~DLT~2920315~INFO     ~Cannot open configuration file: /tmp/dlt-runtime.cfg
[ 3185.043748]~DLT~2920315~INFO     ~Ringbuffer configuration: 500000/10000000/500000
[ 3185.043947]~DLT~2920315~NOTICE   ~Failed to open ECU Software version file.
[ 3185.043965]~DLT~2920315~WARNING  ~Unable to set send timeout Socket operation on non-socket.
[ 3185.043970]~DLT~2920315~INFO     ~Activate connection type: 6
[ 3185.043972]~DLT~2920315~INFO     ~Switched to buffer state for socket connections.
[ 3185.043977]~DLT~2920315~WARNING  ~dlt_daemon_applications_load: cannot open file /tmp/dlt-runtime-application.cfg: No such file or directory

@minminlittleshrimp

Copy link
Copy Markdown
Collaborator Author

@lti9hc please approve and merge this
Thanks 😀

@minminlittleshrimp minminlittleshrimp changed the title daemon: unix socket checking before creating new [Draft] daemon: unix socket checking before creating new Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants