Skip to content

Fix timeout handling for slog messages - #635

Merged
michael-methner merged 2 commits into
masterfrom
fix-qnx-slogger-timeout
Jun 12, 2024
Merged

Fix timeout handling for slog messages#635
michael-methner merged 2 commits into
masterfrom
fix-qnx-slogger-timeout

Conversation

@michael-methner

Copy link
Copy Markdown
Contributor
  • Discard messages after timeout
  • Log warning message only once until a new slog message was logged
    successful

Signed-off-by: Michael Methner michael.methner@de.bosch.com

- Discard messages after timeout
- Log warning message only once until a new slog message was logged
  successful

Signed-off-by: Michael Methner <michael.methner@de.bosch.com>
@michael-methner

Copy link
Copy Markdown
Contributor Author

Hello @ahmetfindi ,
can you please help me with this PR and verify this commit (i do not have QNX system at my hand). It is a improved fix from the commit which you have provided in PR #632 .

Comment thread src/dlt-qnx-system/dlt-qnx-slogger2-adapter.cpp Outdated
Co-authored-by: ahmetfindi <113675774+ahmetfindi@users.noreply.github.com>
@minminlittleshrimp minminlittleshrimp changed the title [DRAFT] Fix timeout handling for slog messages Fix timeout handling for slog messages Jun 12, 2024
@michael-methner
michael-methner merged commit 603f0e4 into master Jun 12, 2024
alexmohr pushed a commit to mercedes-benz/dlt-daemon that referenced this pull request Jun 28, 2024
* Fix timeout handling for slog messages

- Discard messages after timeout
- Log warning message only once until a new slog message was logged
  successful

Signed-off-by: Michael Methner <michael.methner@de.bosch.com>

* Update src/dlt-qnx-system/dlt-qnx-slogger2-adapter.cpp

Co-authored-by: ahmetfindi <113675774+ahmetfindi@users.noreply.github.com>

---------

Signed-off-by: Michael Methner <michael.methner@de.bosch.com>
Co-authored-by: ahmetfindi <113675774+ahmetfindi@users.noreply.github.com>

Issue-ID: APRICOT-522230
Signed-off-by: Ahmet Findikci <ahmet.findikci@mercedes-benz.com>
minminlittleshrimp pushed a commit that referenced this pull request Jul 2, 2024
* Fix timeout handling for slog messages

- Discard messages after timeout
- Log warning message only once until a new slog message was logged
  successful

Signed-off-by: Michael Methner <michael.methner@de.bosch.com>

* Update src/dlt-qnx-system/dlt-qnx-slogger2-adapter.cpp

Co-authored-by: ahmetfindi <113675774+ahmetfindi@users.noreply.github.com>

---------

Signed-off-by: Michael Methner <michael.methner@de.bosch.com>
Co-authored-by: ahmetfindi <113675774+ahmetfindi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants