Skip to content

Refactor: Enable RDF4J reasoner integration#105

Open
claireqiu wants to merge 1 commit into
COVESA:mainfrom
chrizmc:haonan_refactor_support_rdf4j
Open

Refactor: Enable RDF4J reasoner integration#105
claireqiu wants to merge 1 commit into
COVESA:mainfrom
chrizmc:haonan_refactor_support_rdf4j

Conversation

@claireqiu
Copy link
Copy Markdown
Contributor

  • Add RDF4JAdapter C++ class implementing IReasonerAdapter interface
  • Add InferenceEngineType::RDF4J enum with string conversion support
  • Restructure symbolic-reasoner adapters into dedicated adapters/ directory
  • Moved rdfox, rdf4j-reasoner, and pellet adapters to symbolic-reasoner/adapters/
  • Added MODEL_CONFIGURATION_PATH environment variable support
  • Fixed getPathToUseCases() to return dynamic value instead of static initialization
  • Updated CMakeLists.txt paths to reflect new adapter structure
  • Make model config path configurable via MODEL_CONFIGURATION_FILE env var
  • Add README documentation for adapter and engine integration
  • Created docker/rdf4j and docker/rdfox
  • docs: Add reasoner integration guide
  • Delete unused files

- Add RDF4JAdapter C++ class implementing IReasonerAdapter interface
- Add InferenceEngineType::RDF4J enum with string conversion support
- Restructure symbolic-reasoner adapters into dedicated adapters/ directory
- Moved rdfox, rdf4j-reasoner, and pellet adapters to symbolic-reasoner/adapters/
- Added MODEL_CONFIGURATION_PATH environment variable support
- Fixed getPathToUseCases() to return dynamic value instead of static initialization
- Updated CMakeLists.txt paths to reflect new adapter structure
- Make model config path configurable via MODEL_CONFIGURATION_FILE env var
- Add README documentation for adapter and engine integration
- Created docker/rdf4j and docker/rdfox
- docs: Add reasoner integration guide
- Delete unused files

Signed-off-by: Haonan Qiu <haonan.qiu@bmw.de>
@slawr
Copy link
Copy Markdown
Collaborator

slawr commented Apr 9, 2026

Some early observations:

  1. If the example has moved then the link to the example in the online doc needs updating, content source here: https://github.com/COVESA/cdsp/blob/main/docs/doc-site/content/docs/examples/_index.md You might also search the source code for any other links to it that need updating.
  2. Do the IL/KL C4 model component diagrams need updating? If so, we should do that soon as the C4 model is intended to be a primary communication tool with newcomers. For example, I will use them in the Porto AMM introduction session.

@claireqiu
Copy link
Copy Markdown
Contributor Author

Some early observations:

  1. If the example has moved then the link to the example in the online doc needs updating, content source here: https://github.com/COVESA/cdsp/blob/main/docs/doc-site/content/docs/examples/_index.md You might also search the source code for any other links to it that need updating.
  2. Do the IL/KL C4 model component diagrams need updating? If so, we should do that soon as the C4 model is intended to be a primary communication tool with newcomers. For example, I will use them in the Porto AMM introduction session.

for point 1: right. However, I would suggest to make this point an issue and modify it once RDF4J reasoner has been integrated and tested.
for point 2: I don't think it affects as the C4 conceptual designing model. The integration reuses the same conceptual designs as before.

@slawr
Copy link
Copy Markdown
Collaborator

slawr commented Apr 10, 2026

Some early observations:

  1. If the example has moved then the link to the example in the online doc needs updating, content source here: https://github.com/COVESA/cdsp/blob/main/docs/doc-site/content/docs/examples/_index.md You might also search the source code for any other links to it that need updating.
  2. Do the IL/KL C4 model component diagrams need updating? If so, we should do that soon as the C4 model is intended to be a primary communication tool with newcomers. For example, I will use them in the Porto AMM introduction session.

for point 1: right. However, I would suggest to make this point an issue and modify it once RDF4J reasoner has been integrated and tested.

I will leave it to the implementers to decide which to do. If it is to wait please raise the issue and please do not leave it open long. The example list is a natural starting point for newcomers and broken links will not leave a good early impression.

It's a simple one line change and the doc is automatically rebuilt for you.

for point 2: I don't think it affects as the C4 conceptual designing model. The integration reuses the same conceptual designs as before.

OK. Thank you for the clarification. Please keep the model in mind during the follow on steps.

btw I have not done anything with this PR as its marked as Draft.

@claireqiu claireqiu marked this pull request as ready for review April 13, 2026 13:15
@claireqiu
Copy link
Copy Markdown
Contributor Author

Some early observations:

  1. If the example has moved then the link to the example in the online doc needs updating, content source here: https://github.com/COVESA/cdsp/blob/main/docs/doc-site/content/docs/examples/_index.md You might also search the source code for any other links to it that need updating.
  2. Do the IL/KL C4 model component diagrams need updating? If so, we should do that soon as the C4 model is intended to be a primary communication tool with newcomers. For example, I will use them in the Porto AMM introduction session.

for point 1: right. However, I would suggest to make this point an issue and modify it once RDF4J reasoner has been integrated and tested.

I will leave it to the implementers to decide which to do. If it is to wait please raise the issue and please do not leave it open long. The example list is a natural starting point for newcomers and broken links will not leave a good early impression.

It's a simple one line change and the doc is automatically rebuilt for you.

for point 2: I don't think it affects as the C4 conceptual designing model. The integration reuses the same conceptual designs as before.

OK. Thank you for the clarification. Please keep the model in mind during the follow on steps.

btw I have not done anything with this PR as its marked as Draft.

agree:
point 1: issue is created #106

@claireqiu
Copy link
Copy Markdown
Contributor Author

thank you for review and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants