Refactor: Enable RDF4J reasoner integration#105
Conversation
claireqiu
commented
Apr 7, 2026
- Add RDF4JAdapter C++ class implementing IReasonerAdapter interface
- Add InferenceEngineType::RDF4J enum with string conversion support
- Restructure symbolic-reasoner adapters into dedicated adapters/ directory
- Moved rdfox, rdf4j-reasoner, and pellet adapters to symbolic-reasoner/adapters/
- Added MODEL_CONFIGURATION_PATH environment variable support
- Fixed getPathToUseCases() to return dynamic value instead of static initialization
- Updated CMakeLists.txt paths to reflect new adapter structure
- Make model config path configurable via MODEL_CONFIGURATION_FILE env var
- Add README documentation for adapter and engine integration
- Created docker/rdf4j and docker/rdfox
- docs: Add reasoner integration guide
- Delete unused files
- Add RDF4JAdapter C++ class implementing IReasonerAdapter interface - Add InferenceEngineType::RDF4J enum with string conversion support - Restructure symbolic-reasoner adapters into dedicated adapters/ directory - Moved rdfox, rdf4j-reasoner, and pellet adapters to symbolic-reasoner/adapters/ - Added MODEL_CONFIGURATION_PATH environment variable support - Fixed getPathToUseCases() to return dynamic value instead of static initialization - Updated CMakeLists.txt paths to reflect new adapter structure - Make model config path configurable via MODEL_CONFIGURATION_FILE env var - Add README documentation for adapter and engine integration - Created docker/rdf4j and docker/rdfox - docs: Add reasoner integration guide - Delete unused files Signed-off-by: Haonan Qiu <haonan.qiu@bmw.de>
|
Some early observations:
|
for point 1: right. However, I would suggest to make this point an issue and modify it once RDF4J reasoner has been integrated and tested. |
I will leave it to the implementers to decide which to do. If it is to wait please raise the issue and please do not leave it open long. The example list is a natural starting point for newcomers and broken links will not leave a good early impression. It's a simple one line change and the doc is automatically rebuilt for you.
OK. Thank you for the clarification. Please keep the model in mind during the follow on steps. btw I have not done anything with this PR as its marked as Draft. |
agree: |
|
thank you for review and merge the PR. |