len(conv_filter_match) < 50 bug fix#803
Merged
Merged
Conversation
katiebreivik
approved these changes
Jun 16, 2026
katiebreivik
left a comment
katiebreivik
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @astrogina! Love the extra log file writes; future users will def appreciate!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #803 +/- ##
============================================
- Coverage 86.91% 76.14% -10.77%
============================================
Files 40 58 +18
Lines 25542 28171 +2629
Branches 0 985 +985
============================================
- Hits 22198 21448 -750
- Misses 3344 6418 +3074
- Partials 0 305 +305 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d-maclean
pushed a commit
to d-maclean/COSMIC
that referenced
this pull request
Jun 18, 2026
* change empty list to empty dfs * update singles match * updated warnings * took out prints and pdbs --------- Co-authored-by: Gina Chen <gchen99@m005.opa.vera.psc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug where conv_filter_match was being overwritten in each step instead of being added to when it contained a nonzero number but less than 50 binaries.