Skip to content

Fix sampling when multiprocessing and using total_mass as your samplng target#802

Merged
katiebreivik merged 2 commits into
COSMIC-PopSynth:developfrom
TomWagg:fix-sampling
Jun 16, 2026
Merged

Fix sampling when multiprocessing and using total_mass as your samplng target#802
katiebreivik merged 2 commits into
COSMIC-PopSynth:developfrom
TomWagg:fix-sampling

Conversation

@TomWagg

@TomWagg TomWagg commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

This fixes an issue added in v3.7.6 where sample fails if you have total_mass as your sampling target and use multiprocessing.

@TomWagg TomWagg requested a review from katiebreivik June 16, 2026 15:22
@TomWagg TomWagg self-assigned this Jun 16, 2026
@TomWagg TomWagg added the bug label Jun 16, 2026

@katiebreivik katiebreivik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the quick turnaround!

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.14%. Comparing base (8772c07) to head (a637b2a).
⚠️ Report is 173 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/sample/sampler/independent.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #802       +/-   ##
============================================
- Coverage    86.91%   76.14%   -10.77%     
============================================
  Files           40       58       +18     
  Lines        25542    28171     +2629     
  Branches         0      985      +985     
============================================
- Hits         22198    21448      -750     
- Misses        3344     6418     +3074     
- Partials         0      305      +305     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katiebreivik katiebreivik merged commit 4a7b486 into COSMIC-PopSynth:develop Jun 16, 2026
4 of 6 checks passed
@TomWagg TomWagg deleted the fix-sampling branch June 16, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants