Small fix to inifile/arg parsing in cosmic-pop for METISSE#797
Merged
katiebreivik merged 1 commit intoJun 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #797 +/- ##
============================================
- Coverage 86.91% 76.14% -10.77%
============================================
Files 40 58 +18
Lines 25542 28169 +2627
Branches 0 985 +985
============================================
- Hits 22198 21448 -750
- Misses 3344 6416 +3072
- Partials 0 305 +305 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
katiebreivik
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Currently, cosmic-pop will throw a
TypeErrorunder the following specific circumstances:stellar_engineismetissem2_minis commented out (default) orNone(default value when uncommented)This exception is related to how m2_min and m1_min are parsed to set the truncation limits for the IMF. For users who use
qmininstead this can cause a bit of a headache. I changed the indentation levels here to avoid these checks ifm2_minis not passed or is set toNone.The behavior where an exception is thrown if you pass both
qminandm2_minis preserved.