Skip to content

Added check to skip mass loss-block for dt limits when METISSE is active#796

Merged
katiebreivik merged 1 commit into
COSMIC-PopSynth:developfrom
d-maclean:metisse-fix
Jun 15, 2026
Merged

Added check to skip mass loss-block for dt limits when METISSE is active#796
katiebreivik merged 1 commit into
COSMIC-PopSynth:developfrom
d-maclean:metisse-fix

Conversation

@d-maclean

Copy link
Copy Markdown
Contributor

Hello,

This request tries to address an issue I see in some COSMIC-METISSE systems. If the mass loss rate is very high (e.g. during LBV or Wolf Rayet-like winds on an 80 Msun MS star), the timestep limit becomes very small (~1d-16) and causes evolv2 to run out of iterations very quickly.

This change skips that code block if METISSE is active. I do not think this is necessarily an issue since the winds are "baked in" to the tracks, rather than being added on during the timestep. However, I would very much like to be double-checked on this!

Cheers.

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.14%. Comparing base (8772c07) to head (e0aae6a).
⚠️ Report is 170 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #796       +/-   ##
============================================
- Coverage    86.91%   76.14%   -10.77%     
============================================
  Files           40       58       +18     
  Lines        25542    28169     +2627     
  Branches         0      985      +985     
============================================
- Hits         22198    21448      -750     
- Misses        3344     6416     +3072     
- Partials         0      305      +305     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katiebreivik katiebreivik merged commit bf35055 into COSMIC-PopSynth:develop Jun 15, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants