Added check to skip mass loss-block for dt limits when METISSE is active#796
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #796 +/- ##
============================================
- Coverage 86.91% 76.14% -10.77%
============================================
Files 40 58 +18
Lines 25542 28169 +2627
Branches 0 985 +985
============================================
- Hits 22198 21448 -750
- Misses 3344 6416 +3072
- Partials 0 305 +305 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
katiebreivik
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This request tries to address an issue I see in some COSMIC-METISSE systems. If the mass loss rate is very high (e.g. during LBV or Wolf Rayet-like winds on an 80 Msun MS star), the timestep limit becomes very small (~
1d-16) and causes evolv2 to run out of iterations very quickly.This change skips that code block if METISSE is active. I do not think this is necessarily an issue since the winds are "baked in" to the tracks, rather than being added on during the timestep. However, I would very much like to be double-checked on this!
Cheers.