Skip to content

bug: remove hardcoded API token from app.js #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug: remove hardcoded API token from app.js #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ if (app.get('env') == 'development') {
app.use(errorHandler());
}

var token = 'SECRET_TOKEN_f8ed84e8f41e4146403dd4a6bbcea5e418d23a9';
console.log('token: ' + token);

http.createServer(app).listen(app.get('port'), function () {
console.log('Express server listening on port ' + app.get('port'));
});
11 changes: 11 additions & 0 deletions tests/hardcoded-token.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
var fs = require('fs');
var path = require('path');
var test = require('tap').test;

test('no hard-coded API token is defined or logged in app.js', function (t) {
var app = fs.readFileSync(path.join(__dirname, '..', 'app.js'), 'utf8');
t.notMatch(app, /SECRET_TOKEN/, 'no token literal in app.js');
t.notMatch(app, /token\s*=\s*['"`]/, 'no token assigned from a literal');
t.notMatch(app, /console\.log\([^)]*token/i, 'no token written to the log');
t.end();
});
Loading