bug: prevent Zip Slip path traversal in /import zip extraction - #236
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
bug: prevent Zip Slip path traversal in /import zip extraction#236devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Zip Slip (CWE-22) in
POST /import:routes/index.jspassed an attacker-uploaded archive straight tozip.extractAllTo(extracted_path, true), so an entry named../../usr/src/goof/public/about.html(seeexploits/zip-slip/malicious_backup.zip) is written outside/tmp/extracted_files— arbitrary file overwrite as the app user.Extraction now goes through two new helpers in
utils.jsinstead ofextractAllTo:Backslashes are normalized before resolving, and absolute/empty entry names are rejected, so
..\..\x,/etc/passwdanda/../../xare all skipped rather than written.Also bumps
adm-zip0.4.7 → 0.4.16 (0.4.7 has no traversal protection of its own); the enforcement above does not depend on the bump.tests/zip-slip.spec.jscovers the path helper's rejection cases and extracts the real malicious archive, asserting the traversal entry never lands outside the destination whilebackup.txtstill extracts.Devin-Org: engineering
Written by Devin