fix: stored XSS in todo content rendering (CWE-79) - #230
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: stored XSS in todo content rendering (CWE-79)#230devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stored todo content was rendered as raw HTML on the index page:
marked@0.3.5'ssanitize: trueis not a security boundary (multiple known bypasses, e.g.[x](javascript:...)— seeexploits/marked-exploit.sh), so any user-supplied todo could inject script that executed for every viewer. Escaping the value with EJS<%=removes the raw-HTML sink entirely, matching howviews/edit.ejsalready renders the same field.app.jsdrops the now-unusedmarkedrequire and theapp.locals.markedwiring so the unsafe helper isn't reachable from any other template.Devin-Org: engineering
Devin Review