Skip to content

fix: [elliptic] Upgrade elliptic from 6.4.1 to 6.6.1 to resolve CVE-2024-48948 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannahhuh-cog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [elliptic] Upgrade elliptic from 6.4.1 to 6.6.1 to resolve CVE-2024-48948 #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 44 additions & 27 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,8 @@
"nodemon": "^2.0.7",
"snyk": "^1.244.0"
},
"license": "Apache-2.0"
"license": "Apache-2.0",
"overrides": {
"elliptic": "6.6.1"
}
Comment on lines +57 to +59

@devin-ai-integration devin-ai-integration Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Lockfile omits overrides, can break npm ci

package.json declares an overrides block, but the root package in package-lock.json records no matching overrides key. npm normally persists overrides in the lockfile, so its absence leaves the two files out of sync and can make npm ci fail with an EUSAGE error.

Prompt for agents 
package.json adds an overrides block pinning elliptic to 6.6.1, but package-lock.json's root package (packages[""]) does not contain a matching overrides field (searching for 'overrides' in package-lock.json yields no results). When npm regenerates a lockfile with overrides declared, it stores them under packages[""].overrides; the missing field indicates the lockfile was not fully regenerated by npm. This can cause 'npm ci' to fail with an out-of-sync error. Regenerate the lockfile with a recent npm (e.g. npm install --package-lock-only) so the overrides metadata is written into package-lock.json, and verify npm ci succeeds.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally — npm ci is not broken by this.

I regenerated the lockfile with npm install --package-lock-only on npm 10.8.2. This repo's lockfile is lockfileVersion: 2 (hybrid v1/v2), and npm did not write an overrides key into packages[""] — but it did resolve the overridden version in the tree, and npm only enforces the overrides-sync check when the lockfile records one.

Evidence, from a clean checkout of just package.json + package-lock.json on this branch:

$ npm ci --ignore-scripts
added 947 packages in 5s
$ node -e "console.log(require('elliptic/package.json').version)"
6.6.1

No EUSAGE error. Leaving the lockfile as npm generated it.

Comment on lines +57 to +59

@devin-ai-integration devin-ai-integration Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: elliptic is a dev-only transitive dependency

elliptic is marked "dev": true in the lockfile and pulled in transitively through the browserify build chain. The override correctly pins it to 6.6.1, but the CVE scope here is dev/build tooling rather than the production runtime.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

}
Loading