bug: fix Zip Slip in POST /import archive extraction - #217
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
bug: fix Zip Slip in POST /import archive extraction#217devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /importextracted uploaded archives withzip.extractAllTo('/tmp/extracted_files', true)on adm-zip 0.4.7, so an entry named../../usr/src/goof/public/about.htmlwas written outside the extraction dir (Zip Slip, CWE-22, arbitrary file overwrite as the app user).The vulnerable API is no longer called.
utils.safe_extract_zip(zip, dest)now writes entries itself, running eachentry.entryNamethroughutils.safe_extract_path(root, name):which rejects
../segments, absolute names and backslash/drive-relative names. adm-zip is also bumped 0.4.7 -> 0.4.16 (defense in depth; the sink fix stands on its own). Regression test intests/zip-slip.spec.js(uses the committedexploits/zip-slip/malicious_backup.zip), 10/10 withNODE_OPTIONS=--openssl-legacy-provider ./node_modules/.bin/tap tests/zip-slip.spec.js --no-coverage.Devin-Org: engineering
Devin Review