fix: upgrade vulnerable Python/WebUI dependencies (Snyk P0) - #335
Open
vanessasalas-cog wants to merge 2 commits into
Open
fix: upgrade vulnerable Python/WebUI dependencies (Snyk P0)#335vanessasalas-cog wants to merge 2 commits into
vanessasalas-cog wants to merge 2 commits into
Conversation
Co-Authored-By: vanessa.salas <vanessa.salas@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: vanessa.salas <vanessa.salas@cognition.ai>
|
CI note — the failures on this branch are not from these dependency changes, and none are fixable without going outside its scope:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
Dependency-hygiene only, from the Snyk audit of
f72da88. No source or build changes.Poetry lock moves (
poetry.lock):certifi 2024.2.2 -> 2026.7.22,idna 3.6 -> 3.19,jinja2 3.1.3 -> 3.1.6,requests 2.31.0 -> 2.32.5,tqdm 4.66.2 -> 4.70.0,urllib3 2.2.1 -> 2.6.3,protobuf 4.25.3 -> 4.25.9,sentencepiece 0.1.99 -> 0.2.2. Manifest constraints changed only where the lock needed room:sentencepiece = ">=0.2.1,<0.3.0"inpyproject.toml, the same range ingguf-py/pyproject.toml(the optional extra there still capped at<=0.2.0, i.e. the vulnerable version stayed permitted in the package whosevocab.pyactually imports it), andpillow~=12.3.0intools/mtmd/requirements.txt. WebUI is lockfile-only —mdast-util-to-hast 13.2.0 -> 13.2.1,package.jsonuntouched.Root Poetry project: 47 issues / 81 vulnerable paths -> 30 issues / 42 paths. WebUI: 1 issue / 4 paths -> clean.
Deliberately out of scope:
transformers(4.38.1) andtorch— the High deserialization findings have no fix belowtransformers5.x and none at all fortorch; mitigate operationally (trusted checkpoints,weights_only=True). These, plus transitivefilelock, are the bulk of the residual root findings.requestsstops at 2.32.5 andurllib3at 2.6.3 because 2.33.0 / 2.7.0 require Python >= 3.10 and this project supports>=3.9. What remains is one Medium (insecure temp file,SNYK-PYTHON-REQUESTS-15763443) andSNYK-PYTHON-URLLIB3-16642024; dropping 3.9 support to close them is a separate decision.snyk testontools/mtmd/requirements.txtresolvespillowto 12.1.1 regardless of the~=12.3.0cap, so the 15 Pillow findings still show. 12.3.0 is published on PyPI and is the Snyk-stated fixed version for them..github/workflows/snyk-security-scan.ymlfixes (it installs paths from a different project, targets a different Snyk org, and runs SAST only — so it would have caught none of the above) are not in this PR.Verified with per-manifest
snyk test,poetry check, andpre-commit run --fileson the changed files. Note for anyone running lint locally:pre-commitcannot install its own env on this repo —flake8-no-printpinsflake8==4.0.1against the configured 7.0.0, which is a preexisting config break unrelated to this change.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/f9f84d20063147bba263af257c1afaac
Requested by: @vanessasalas-cog
Devin Review