MBA-2247: Migrate angular2-hn to React + TypeScript - #706
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
MBA-2247: Migrate angular2-hn to React + TypeScript#706devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds the Hacker News PWA in React with feature parity, as a self-contained app under
react/(Vite + React 18 + TS strict + react-router v6 + vite-plugin-pwa + Vitest). No Angular files are modified or deleted — both implementations live side by side.Key mappings from the Angular app:
app.routes.ts:/→/news/1;/{news,newest,show,ask,jobs}/:page→FeedPage;/item/:idand/user/:idareReact.lazy-loaded (parity with Angular lazy modules).HackerNewsAPIService→ typedfetchclient (src/api/hackerNewsApi.ts) withAbortControllercleanup inuseEffect; poll items fetch optionsid+1..id+nviaPromise.alland computepoll_votes_count.SettingsService→SettingsProvider/useSettings()context with the same localStorage keys (theme,openLinkInNewTab,titleFontSize,listSpacing) and the sameprefers-color-schemefallback behavior when no theme is saved._themes.scsscascades from a theme class onto global class names (.wrapper,.subtext, …); the app shell renders<div className={settings.theme}>exactly likeapp.component.html.CommentPipe→formatCommentCount()util; recursiveCommentcomponent with collapse and deleted states.vite-plugin-pwa(generateSW) with ported manifest and icons, precaching the app shell + assets to mirrorngsw-config.json.Verification
In
react/:npm run lint,npm run build(tsc --noEmit + vite build),npm test -- --runall pass;vite previewserves the app.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/164e49519e9e4ee48c749f721bc49d48
Open in Devin Desktop: https://app.devin.ai/desktop/session/164e49519e9e4ee48c749f721bc49d48?variant=devin