feature: PR 7/8 — React User page - #704
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 7 of the Angular→React migration: the user profile page. The PR 4
Userplaceholder becomes a real port ofuser.component.*, still lazy-loaded. Nothing undersrc/app/changes.Feed/ItemDetails(ignore-flag stale-response guard,errorMessagereset per fetch), error wording preserved verbatim:Could not load user <id>.ngOnInithere did not scroll to top (unlikeItemDetails), and the template has nomain-contentwrapper — both preserved.Location.back()→useNavigate()(-1); as in PR 6 the back-buttonspangainsrole="button",tabIndex={0}and Enter/Space handling.User.scssneeded the same treatment asComment.scss: Angular's:host >>> prebecame.profile pre.Heads-up unrelated to this PR: the upstream API has dropped the endpoint this page depends on —
GET https://node-hnapi.herokuapp.com/user/pgreturnsCannot GET /user/pgwhile/news?page=1is 200. So the user page renders the error state for every user today, in the Angular app as much as in this port. I kept parity rather than silently switching data sources; migrating to the Firebase HN API is a separate decision.Verification
npm run typecheck:reactandnpx vite buildpass with theUserlazy chunk (JS + CSS) still emitted.Live:
/user/pgand a nonexistent id both render the exact error copy (upstream 404, see above):Because the endpoint is gone, the success path was verified against a temporarily stubbed response (stub fully reverted afterwards —
git diffclean). Withabout, rendering the HTML body and.other-details:Without
about,.other-detailscorrectly absent:Back button from a pushed profile route returned to
/news/1.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/e6419ebe67ff4f749fe1573a8e26cd07
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review