Skip to content

Remove Angular, React becomes the app (migration 8/8) - #696

Open
charityquinn-cognition wants to merge 1 commit into
devin/react-migration-7-pwafrom
devin/react-migration-8-cleanup
Open

Remove Angular, React becomes the app (migration 8/8)#696
charityquinn-cognition wants to merge 1 commit into
devin/react-migration-7-pwafrom
devin/react-migration-8-cleanup

Conversation

@charityquinn-cognition

@charityquinn-cognition charityquinn-cognition commented Aug 25, 2026

Copy link
Copy Markdown

Summary

Top of the stack, on #695. Deletes Angular and promotes the React build to the only build. Mostly deletions: 78 files, ~-11.9k lines (most of it yarn.lock).

  • Removed src/ entirely (app/, environments/, index.html, main.ts, polyfills.ts, styles.scss, test.ts) plus angular.json, tslint.json, karma.conf.js, ngsw-config.json, browserslist, tsconfig.app.json, tsconfig.spec.json, and e2e/ (protractor).
  • tsconfig.react.jsontsconfig.json, replacing the Angular one.
  • Dependencies: dropped all @angular/*, the CLI/devkit/compiler-cli/language-service, rxjs + rxjs-compat, zone.js, tslib, node-fetch, unfetch, codelyzer, tslint, karma/jasmine/protractor and ts-node. Removed via yarn, so yarn.lock shrinks accordingly. Scripts lose their react: prefix and become the primary ones (dev/start/build/preview); test, lint and e2e are removed rather than left as commands that fail — there is no test tooling left in the repo (the Angular suite was the CLI default specs, which went with src/).
  • Vite build.outDir moves dist/reactdist, which is what firebase.json hosting already serves; its ** → /index.html SPA rewrite needed no change.
  • .travis.yml: Node 6.9 → 20, drops the global Angular CLI install, and runs yarn install --frozen-lockfile && yarn build. This also fixes the ERR_OSSL_EVP_UNSUPPORTED failure noted in React tooling scaffold (migration 1/8) #689 — the legacy Webpack 4 build that hit it no longer exists.
  • README/CONTRIBUTING retargeted to React + Vite + Yarn, with the stale npm run precache / static-serve steps (scripts that don't exist) replaced by yarn build / yarn preview.

Not renamed: React source stays in src-react/ rather than moving to src/. A directory rename here would bury the actual removals in rename noise; it's a trivial follow-up if you'd prefer the conventional layout.

Remaining "angular" references are intentional: the package name, .firebaserc project, the deployed Firebase URL, the manifest's app name and the angular2-hn-assets cache name — all identity/branding, not tooling.

Verified: clean rm -rf node_modules && yarn install --frozen-lockfile resolves no Angular packages; yarn build emits dist/ with sw.js + manifest.json; yarn dev and yarn preview both serve; feed → comments → back → theme switch all still work after the removal.

Devin-Org: engineering

Link to Devin session: https://app.devin.ai/sessions/1ff25c6cf2f949458f82cc596fc79c65
Requested by: @charityquinn-cognition


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Devin Review (Staging)
Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/react-migration-8-cleanup branch 2 times, most recently from 75c314c to 19d061c Compare August 25, 2026 22:34
Co-Authored-By: Charity Quinn <charity.quinn@cognition.ai>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/react-migration-8-cleanup branch from 19d061c to 8aa2b61 Compare August 25, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant