Remove Angular, React becomes the app (migration 8/8) - #696
Open
charityquinn-cognition wants to merge 1 commit into
Open
Remove Angular, React becomes the app (migration 8/8)#696charityquinn-cognition wants to merge 1 commit into
charityquinn-cognition wants to merge 1 commit into
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
force-pushed
the
devin/react-migration-8-cleanup
branch
2 times, most recently
from
August 25, 2026 22:34
75c314c to
19d061c
Compare
Co-Authored-By: Charity Quinn <charity.quinn@cognition.ai>
devin-ai-integration
Bot
force-pushed
the
devin/react-migration-8-cleanup
branch
from
August 25, 2026 22:48
19d061c to
8aa2b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Top of the stack, on #695. Deletes Angular and promotes the React build to the only build. Mostly deletions: 78 files, ~-11.9k lines (most of it
yarn.lock).src/entirely (app/,environments/,index.html,main.ts,polyfills.ts,styles.scss,test.ts) plusangular.json,tslint.json,karma.conf.js,ngsw-config.json,browserslist,tsconfig.app.json,tsconfig.spec.json, ande2e/(protractor).tsconfig.react.json→tsconfig.json, replacing the Angular one.@angular/*, the CLI/devkit/compiler-cli/language-service,rxjs+rxjs-compat,zone.js,tslib,node-fetch,unfetch,codelyzer,tslint, karma/jasmine/protractor andts-node. Removed via yarn, soyarn.lockshrinks accordingly. Scripts lose theirreact:prefix and become the primary ones (dev/start/build/preview);test,lintande2eare removed rather than left as commands that fail — there is no test tooling left in the repo (the Angular suite was the CLI default specs, which went withsrc/).build.outDirmovesdist/react→dist, which is whatfirebase.jsonhosting already serves; its** → /index.htmlSPA rewrite needed no change..travis.yml: Node 6.9 → 20, drops the global Angular CLI install, and runsyarn install --frozen-lockfile && yarn build. This also fixes theERR_OSSL_EVP_UNSUPPORTEDfailure noted in React tooling scaffold (migration 1/8) #689 — the legacy Webpack 4 build that hit it no longer exists.npm run precache/static-servesteps (scripts that don't exist) replaced byyarn build/yarn preview.Not renamed: React source stays in
src-react/rather than moving tosrc/. A directory rename here would bury the actual removals in rename noise; it's a trivial follow-up if you'd prefer the conventional layout.Remaining "angular" references are intentional: the package name,
.firebasercproject, the deployed Firebase URL, the manifest's app name and theangular2-hn-assetscache name — all identity/branding, not tooling.Verified: clean
rm -rf node_modules && yarn install --frozen-lockfileresolves no Angular packages;yarn buildemitsdist/withsw.js+manifest.json;yarn devandyarn previewboth serve; feed → comments → back → theme switch all still work after the removal.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/1ff25c6cf2f949458f82cc596fc79c65
Requested by: @charityquinn-cognition
Devin Review