Models, fetch-based API, settings context (migration 2/8)

[charityquinn-cognition]

Summary

Stacked on #689. Ports the framework-agnostic layer: models, the HN API service, the settings service, and the comment pipe. No UI yet, so nothing is wired up — PR3 onward consumes this.

Models (src-react/shared/models/) become plain interfaces/types, keeping the API's wire names verbatim (time_ago, comments_count, poll_votes_count, and the misspelled crated_time) so no mapping layer is needed. Story.type keeps the item-kind union 'poll' | 'story' | 'job'; the feed names are a separate union, since feed-type.type.ts was overloading one type for both concerns:

export type FeedName = 'news' | 'newest' | 'show' | 'ask' | 'jobs';

API (shared/api/hackernewsApi.ts) drops RxJS for async/await over fetch, same baseUrl and endpoints. Two behavioral notes:

• fetchJson now throws on non-2xx; the Angular version resolved with the error body, so a 500 could reach the UI as a "story".
• the poll loop is awaited to completion before returning, instead of Angular's fire-and-forget subscriptions that mutated story.poll after the caller had already received it:

const pollResults = await Promise.all(story.poll.map((_, i) => fetchPollContent(story.id + i + 1)));
story.poll = pollResults;
story.poll_votes_count = pollResults.reduce((total, r) => total + r.points, 0);

Settings (shared/settings/SettingsContext.tsx) becomes context + provider + useSettings(), preserving the localStorage keys (openLinkInNewTab, theme, titleFontSize, listSpacing), the prefers-color-scheme: dark default with a live matchMedia listener (cleaned up on unmount), and the same mutators (toggleSettings, toggleOpenLinksInNewTab, setTheme, setFont, setSpacing). useSettings throws outside the provider rather than returning undefined.

comment.pipe.ts → formatComments(count) utility, same output strings.

Verified: yarn react:build passes; GET /news?page=1 against the live API returns 30 stories through the new module.

Devin-Org: engineering

Link to Devin session: https://app.devin.ai/sessions/1ff25c6cf2f949458f82cc596fc79c65
Requested by: @charityquinn-cognition

---

Devin Review

Status	Commit
⚪ Not started	—

Run Devin Review

---

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

📝 Info: Saved theme applied only after first paint

getInitialSettings hardcodes theme: 'default' and reads the persisted theme only inside a later useEffect (SettingsContext.tsx). The Angular service applied it in the constructor before render, so users with a saved night theme can see a brief default-theme flash.

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

Accurate. getInitialSettings deliberately doesn't read theme synchronously because the effect that applies it also subscribes to prefers-color-scheme, and the saved value has to win over the media query — doing it in one place avoided duplicating that precedence logic. The flash is real though; the fix is to seed theme from localStorage in the initializer and let the effect only handle the media-query default when nothing is saved. Flagging to the requester rather than folding a behavior tweak into this PR unprompted.