Skip to content

Phase 8: cleanup, docs and final verification - #687

Open
devin-ai-integration[bot] wants to merge 1 commit into
migration/phase7-pwafrom
migration/phase8-cleanup
Open

Phase 8: cleanup, docs and final verification#687
devin-ai-integration[bot] wants to merge 1 commit into
migration/phase7-pwafrom
migration/phase8-cleanup

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 25, 2026

Copy link
Copy Markdown

Summary

Final phase of the Angular → React migration (stacked on #685). Deletes the now-dead Angular tree — src/app/ (modules, components, services, pipes, SCSS), src/main.ts, src/environments/, src/index.html, src/manifest.json — 2.4k lines with no remaining referrers; the React equivalents have been live since #684 and the manifest is generated by vite-plugin-pwa since #685.

With those files gone, tsconfig.json no longer needs to hide them from the type checker:

-"include": ["src", ...], "exclude": ["src/app", "src/environments", "src/main.ts"]
+"include": ["src", ...]

.travis.yml dropped Node 6.9 / global @angular/cli and now runs the real gates (npm ci, npm run lint, npm test, npm run build) on Node 20, with firebase-tools moved into after_success since it is only needed to deploy. firebase.json is untouched — it already serves dist/ and rewrites ** to index.html, which is what client-side routing needs. README/CONTRIBUTING now describe the Vite workflow (npm start on 4200, npm run build, npm run preview for the service worker) instead of the ejected-Webpack + npm run precache flow.

Verification

npm run lint, npm test (52 tests, 11 files) and npm run build (43 precached entries) all pass. Against the dev server in headless Chromium: / and /bogus/1 redirect to /news/1; news/newest/show/ask/jobs and /news/2 each render 30 stories; an item page renders 230 recursive comments and [-] toggles to [+]; picking the night theme sets the wrapper class and localStorage.theme and survives a reload; the mobile layout renders at 390px.

One pre-existing upstream break, not caused by the migration: GET https://node-hnapi.herokuapp.com/user/pg returns Cannot GET /user/pg, so /user/:id shows its error state. Angular's hackernews-api.service.ts called the exact same path, so behavior is unchanged.

feed
night theme
mobile

Remaining

Nothing — this completes the 8-phase migration (#679#685). PRs are stacked, so merge bottom-up starting at #679.

Devin-Org: engineering

Link to Devin session: https://app.devin.ai/sessions/f5e6c49cc7f344bf80df57ffee2e7939
Requested by: @abboudp


Note

Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Devin Review (Staging)

Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants