Phase 8: cleanup, docs and final verification - #687
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Phase 8: cleanup, docs and final verification#687devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final phase of the Angular → React migration (stacked on #685). Deletes the now-dead Angular tree —
src/app/(modules, components, services, pipes, SCSS),src/main.ts,src/environments/,src/index.html,src/manifest.json— 2.4k lines with no remaining referrers; the React equivalents have been live since #684 and the manifest is generated byvite-plugin-pwasince #685.With those files gone,
tsconfig.jsonno longer needs to hide them from the type checker:.travis.ymldropped Node 6.9 / global@angular/cliand now runs the real gates (npm ci,npm run lint,npm test,npm run build) on Node 20, withfirebase-toolsmoved intoafter_successsince it is only needed to deploy.firebase.jsonis untouched — it already servesdist/and rewrites**toindex.html, which is what client-side routing needs. README/CONTRIBUTING now describe the Vite workflow (npm starton 4200,npm run build,npm run previewfor the service worker) instead of the ejected-Webpack +npm run precacheflow.Verification
npm run lint,npm test(52 tests, 11 files) andnpm run build(43 precached entries) all pass. Against the dev server in headless Chromium:/and/bogus/1redirect to/news/1; news/newest/show/ask/jobs and/news/2each render 30 stories; an item page renders 230 recursive comments and[-]toggles to[+]; picking the night theme sets the wrapper class andlocalStorage.themeand survives a reload; the mobile layout renders at 390px.One pre-existing upstream break, not caused by the migration:
GET https://node-hnapi.herokuapp.com/user/pgreturnsCannot GET /user/pg, so/user/:idshows its error state. Angular'shackernews-api.service.tscalled the exact same path, so behavior is unchanged.Remaining
Nothing — this completes the 8-phase migration (#679–#685). PRs are stacked, so merge bottom-up starting at #679.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/f5e6c49cc7f344bf80df57ffee2e7939
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review