Phase 5: page components - #683
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…to React Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 of the Angular → React migration (stacked on #682). Route-level components in
src/pages/plus the app chrome insrc/components/;App.tsxstill renders the placeholder, so nothing is mounted until Phase 6 adds the router.Feed.tsxreadsfeedType/pagefromuseParams(Angular carriedfeedTypein static routedata), fetches on every param change, and deriveslistStart = (page - 1) * 30 + 1.window.scrollTo(0, 0)now runs when the stories actually arrive rather than in the observable's completion callback, and each render is one of loader / error / list instead of three co-existing*ngIfbranches.ItemDetails.tsx: title/subtext/poll bars/comment list,goBackviauseNavigate(-1)(wasLocation.back()),dangerouslySetInnerHTMLforitem.contentand poll option content, and the conditionalitem-header/head-marginclasses on the laptop block. It reuseshasUrlfromItem.tsxinstead of duplicating the getter.User.tsx: profile fields, optional about block,goBack,Could not load user <id>.error.Header.tsx: feed links becomeNavLinks (routerLinkActive→className={({ isActive }) => ...}), the cog togglesshowSettings,scrollTopis preserved, and<Settings />renders only whensettings.showSettings.Footer.tsxis a straight port.User.scss's:host >>> prebecomes.profile pre. Dropped.item-block { display: block }fromFeed.scss— it existed to make Angular's inline<item>custom element a block, andItem.tsxrenders adiv.fetch— feed params → request URL,startoffset, Prev/More visibility rules, jobs header, per-page error copy, item body/comments, poll bar widths frompoints / poll_votes_count, back navigation, user profile/about/error, and header active link + settings toggle.Verification
npm run lint,npm test(47 passed) andnpm run buildpass.Remaining
Phases 6–8: routing/app composition (
SettingsProvider, theme wrapper, routes), PWA, Angular cleanup + docs.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/f5e6c49cc7f344bf80df57ffee2e7939
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review