React migration phase 2d: user profile page - #571
Open
vibhaseshadri-cognition wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the Angular
UserComponent(src/app/user/*) to React, replacing theweb/src/pages/UserPage.tsxplaceholder. DOM structure, class names and copy are kept identical to the Angular template.Behaviour mapping:
route.params.subscribe(...)→useEffectkeyed onuseParams().id, re-fetching (and clearinguser/errorMessage) when the id changes, with acancelledflag so a stale response can't overwrite newer state.*ngIfchain exactly:!user && !errorMessage→<Loader />,!user && errorMessage !== ''→<ErrorMessage message={Could not load user ${id}.} />, otherwise the.profilemarkup.[innerHTML]="user.about"→dangerouslySetInnerHTML, only rendered whenaboutis set.Location.back()→useNavigate()(-1)on the.back-buttonspan.web/src/user/user.scssis the component SCSS verbatim with imports repointed atweb/src/styles/; the Angular-only:host >>> predeep selector becomes.profile pre(same effect,aboutHTML is rendered inside.profile).Tests (
web/src/user/UserPage.test.tsx) cover the loader→profile transition, the full profile markup, a user withoutabout, the error state, and the back button (asserted via realMemoryRouterhistory, not a mockeduseNavigate).npm run lint,npm test(32 passing) andnpm run buildall pass. Base branch is the phase 1 branch, notmaster.Rendered locally against a stubbed API response:
Link to Devin session: https://app.devin.ai/sessions/a13b52a5d39c4bea9eef18845250b691
Requested by: @vibhaseshadri-cognition
Devin Review