Conversation
From a full review. Most impactful first:
- cut-release.sh: group() returned 1 on an empty changelog section, so under `set -e`
a bare `group` call aborted the whole release on a patch with no feat commits (v2.4.0
only survived by having both feat+fix). Use `if` so an empty section returns 0.
- mise/dotnet.toml: the `audit` verb piped `dotnet list` straight into a negated grep,
so if `dotnet list` itself errored the negation passed GREEN. Capture output, fail on
a non-zero `dotnet list`, then grep.
- _ts.yml habits: add the baseline-present guard + pinned setup-python the other three
stacks have — a TS repo with no snooze.json got a hard error instead of a graceful skip,
and ran against the runner's default Python.
- gate.yml: forward `habit_hooks_plugin` (declared on every internal, never exposed on
the facade) with a per-stack fallback; fix the stale "java | ts | php" description to
include dotnet.
- foundry-init.sh: fetch the mise-template-consumed scripts (foundry-verb-wrap,
foundry-loop-report, npm-audit-ratchet.mjs, foundry-flaky) into $WD/scripts, not repo-
root scripts/ — a monorepo (WD=backend) couldn't find them via {{config_root}}/scripts.
- _java/_php/_ts.yml: fix the smell summary's doc path (presets/agent/code-standards.md).
- lint-workflows.yml: shellcheck the extensionless foundry-verb-wrap too.
- commitlint.yml: comment referenced release-please (now cut-release.sh).
Left as-is: the semgrep/cache pinned-SHA skews (#11) — each internally consistent and
likely deliberate; flagged, not changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A correctness sweep (from a full read of the workflows, templates, scripts, tests, docs). By severity:
Critical
cut-release.sh—group()returned 1 on an empty changelog section, so underset -ea baregroupcall aborted the whole release on a patch with nofeatcommits (v2.4.0 only survived because it happened to have both feat+fix). Now usesif, so an empty section returns 0. Verified.Should-fix
mise/dotnet.toml—auditfeddotnet listinto a negated grep, so adotnet listerror passed green (the fail-green class). Now captures output, fails on non-zerodotnet list, then greps._ts.ymlhabits — added the baseline-present guard + pinnedsetup-pythonthe other stacks have (a TS repo with nosnooze.jsonhard-errored instead of skipping; ran against the runner's default Python).gate.yml— forwardshabit_hooks_plugin(declared on every internal, never exposed on the facade) with a per-stack fallback;stackdescription now includesdotnet.foundry-init.sh— fetches template-consumed scripts into$WD/scriptsnot repo-rootscripts/, so a monorepo (WD=backend) can find them via{{config_root}}/scripts._java/_php/_ts.yml— corrected the smell-summary doc path topresets/agent/code-standards.md.Minor
lint-workflows.ymlshellchecks the extensionlessfoundry-verb-wrap;commitlint.ymlcomment now referencescut-release.shnot release-please;foundry-initalso fetchesfoundry-flakyfor the opt-intest:flakyverb.Left as-is: the semgrep/cache pinned-SHA skews — each internally consistent, likely deliberate; flagged not changed.