feat(java): route facade SpotBugs through a mise verb - #36
Merged
Merged
Conversation
…s` verb
The facade's opt-in SpotBugs job ran `./gradlew ${{ inputs.spotbugs_task }}` directly
in working_directory — which breaks for a root-Gradle monorepo (no gradlew in the
package dir). Route it through a `spotbugs` mise task instead, exactly like `novar`:
the workflow calls `mise run spotbugs`, and the consumer's mise.toml decides the Gradle
call. The java template defaults it to `./gradlew spotbugsMain`; a monorepo package
overrides it (`../gradlew :backend:spotbugsMain`).
`spotbugs` stays auxiliary — NOT one of the six contract verbs and not in `gate`.
Removes the now-unused `spotbugs_task` facade input (no consumer sets it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The facade's opt-in SpotBugs job ran
./gradlew ${{ inputs.spotbugs_task }}inworking_directory— which breaks for a root-Gradle monorepo (nogradlewin the package dir; jobbuddy's backend is../gradlew :backend:...).Route it through a
spotbugsmise task, exactly likenovaralready works: the workflow callsmise run spotbugs, and the consumer'smise.tomldecides the Gradle call.mise/java.tomlgains[tasks.spotbugs]=./gradlew spotbugsMain(the single-project default).../gradlew :backend:spotbugsMain).spotbugsstays auxiliary — not one of the six contract verbs, not ingate.spotbugs_taskfacade input (no consumer sets it).Unblocks migrating jobbuddy's backend to consume
gate.yml@v2withspotbugs: true.