P1B: Refactor (packages/app/e2e/performance/timeline/session-tab-switch-metrics.ts:43): Complex binary expression - #86
Open
halammari wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #79
Type of change
What does this PR do?
This PR refactors by splitting the complex condition in 'isCorrectDestination' into separate checks to make it easier to follow. I also moved the bottom-anchor check into a small helper function. The existing tests still pass after the change.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
bun test ./e2e/performance/unit/session-tab-switch-metrics.test.tsand 5 tests passed, 0 failed.qlty smells --no-snippets packages/app/e2e/performance/timeline/session-tab-switch-metrics.tsand theComplex binary expressionissue is no longer reported.Screenshots / recordings
No UI change.
Complex binary expressionreported at line 43.Complex binary expressionis no longer reported for the refactored file.Checklist
If you do not follow this template your PR will be automatically rejected.