Refactor (packages/codemode/src/values.ts:44): Complex binary expression

[DikaSy]

P1B: Starter Task: Refactoring PR

Use this pull request template to briefly answer the questions below in one to two sentences each.

1. Issue

Link to the associated GitHub issue:
This PR resolves issue #16.

Full path to the refactored file:
packages/codemode/src/values.ts

What do you think this file does?
This file defines sandbox wrapper classes (such as SandboxDate, SandboxRegExp, SandboxURL, SandboxPromise, and SandboxMap) and exports type-guard utilities to safely inspect, validate, and isolate runtime values within the sandboxed environment. It serves as a critical boundary layer to securely manage and track data types without exposing native JavaScript objects.

What is the scope of your refactoring within that file?
The refactoring scope is strictly focused on isSandboxValue() at line 44 of packages/codemode/src/values.ts, where a long, complex chain of binary instanceof checks was replaced with a more concise array lookup.

Which Qlty‑reported issue did you address?
I addressed the "Complex binary expression" code smell at line 44 in isSandboxValue(), which was caused by multiple chained logical OR (||) operations evaluating type instances.

2. Refactoring

How did the specific issue you chose impact the codebase’s maintainability?
The long chain of logical OR conditions increased cognitive complexity and reduced readability, making the type guard difficult to scan and highly error-prone to maintain. Adding or removing new sandbox classes required modifying a brittle conditional statement, increasing the risk of syntax errors.

What changes did you make to resolve the issue?
I extracted all supported sandbox class constructors into a private module-level constant (SANDBOX_CLASSES) and refactored isSandboxValue() to use a clean .some(cls => value instanceof cls) lookup instead of repeated conditional checks.

How do your changes improve maintainability? Did you consider alternatives?
This change separates class registration from validation logic, meaning new sandbox types can be added directly to the array without increasing expression complexity. Alternative approaches, such as manual type checks, were considered but proved to be less declarative, overly verbose, and failed to reduce the cognitive load.

3. Validation

How did you validate that the change is correct?
To validate correctness, I created a comprehensive unit test suite (packages/codemode/test/values.test.ts) using the Bun testing framework. This file rigorously tests the implementation through several distinct suites:

• Code Smell Guards: By inspecting the stringified function source, tests actively ensure that chained || operators and repeated instanceof checks remain eliminated from the implementation.
• Refactored Logic Verification: Ensures the new .some() logic correctly identifies target classes while successfully short-circuiting to reject excluded types like SandboxPromise.
• Class-Specific Unit Tests: Validates the initialization, properties, and edge cases (e.g., NaN date timestamps, complex regex flags) for all individual sandbox classes like SandboxDate, SandboxMap, and SandboxURL.
• Exhaustive Positive/Negative Cases: Verifies that subclasses and Object.create instances are accurately identified, while strictly rejecting duck-typed structural imitations, native JavaScript built-ins, arrays, and primitive values.

Finally, I verified overall system integrity in the DevContainer environment by running local test coverage reports, bun lint, CI typecheck, CI test, and qlty smells.

Validation Screenshots & Evidence

1. Code Coverage

• Test File-Specific Code Coverage (values.ts - Before Refactor):

• Test File-Specific Code Coverage (values.ts - After Refactor):

2. Test Execution

• File-Specific Test Execution (packages/codemode/test/values.test.ts - Before Refactor):

• File-Specific Test Execution (packages/codemode/test/values.test.ts - After Refactor):

3. Continuous Integration & Code Quality

• Linter Check (bun lint):

• CI Pipeline Status (CI Typecheck & CI Test):

4. Qlty Smells Verification

• Qlty Smells (packages/codemode/src/values.ts - Before Refactor):

• Qlty Smells (packages/codemode/src/values.ts - After Refactor):