P1B: Refactor (packages/core/src/cross-spawn-spawner.ts: 32): Function with many returns (count = 8) #55

[amtrtt27]

1. Issue

---

Link to the associate GitHub issue: #55

Full path to the refactored file: packages/core/src/cross-spawn-spawner.ts

What do you think this file does?
This file connects Node.js child processes to Effect's ChildProcess API, handles command execution, I/O environment settings, piping, errors, and process lifecycle operations.

What is the scope of your refactoring within that file?
The toTag() function with lines 32-60.
I also added some tests for better coverage.

Which Qlty-reported issue did you address?
Function with many returns had 8 different return statements.

2. Factoring

---

How did the specific issue you chose impact the codebase's maintainability?
The function had many return statements, and this made the control flow harder to follow and understand. This made future changes more difficult because a developer has to check several different exit points to understand the function's behavior.

What changes did you make to resolve the issue?
I refactored the function to reduce the number of return statements by storing the result in a variable and returning it through a single return path at the end of the function.

How do your changes improve maintainability? Did you consider alternatives?
The refactoring makes the function easier to read, debug, and modify because the control flow is more consistent and the final result is returned from one place. I considered keeping some early returns, but chose a single return path because it directly addressed the multiple-return issue while preserving the original behavior.

3. Validations

---

How did you validate that the change is correct?
I validated the change by running the relevant lint, typecheck, and test commands locally to make sure the refactoring did not introduce errors and that the function still behaves as expected.

Attach a screenshot of the test coverage showing the lines were executed by the tests

Attach a screenshot showing the tests that cover the change passing during CI

Attach a screenshot of qlty smells --no-snippets packages/core/src/cross-spawn-spawner.ts showing fewer reported issues BEFORE the changes

Attach a screenshot of qlty smells --no-snippets packages/core/src/cross-spawn-spawner.ts showing fewer reported issues AFTER the changes

Screenshot of bun lint passing locally

Screenshot of bun test passing locally
Here I suppressed the individual test lines and keep the summary output only.