Skip to content

npm run setup-device is broken: scripts/setup-device.mjs imports a file deleted in v2.1.0 (and it still ships) #42

Description

@Shinrai

Problem

scripts/setup-device.mjs imports src/lib/adb/setup.mjs, which was deleted in v2.1.0. So npm run setup-device fails with a module-not-found error. The script is still in the published tarball (scripts/setup-device.mjs, 1.6 kB in the 2.1.7 package), so anyone following the README's device-setup step hits it.

Found during the release-docs backfill (#41).

Fix

Either restore the setup flow on top of the current v2 API, or remove the script, its npm script entry and the README instructions. If removed, document the replacement setup steps. Add a smoke test that imports every file under scripts/ so a dangling import fails CI.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: cliTouches CLI / executable / bin entry pointspriority: highNeeds attention soon — not blocking, but don't let it sitstatus: implementedBuilt and deployed, but not yet fully tested/verifiedtype: bugSomething is broken or not behaving as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions