release: v1.1.3 - run the in-repo PR mirror job instead of skipping it - #79
Merged
Merged
Conversation
The Required PR Check mirror job was skipped on the `pull_request` run of an in-repo feature PR, with a conditional name keeping the skipped check off `✅ Required PR Check`. GitHub never evaluates a skipped job's `name:`, so every in-repo PR showed the raw expression as a check name. The job now uses `if: always()` and never skips, so its name is always evaluated. On the in-repo PR path it lands on `⏭️ Required PR Check (reported by the push run)` and passes as a no-op; the push run still posts `✅ Required PR Check`. Every path that posts the required name keeps `needs: ci`, so that check still only exists once the full test matrix for the SHA has finished. Synced from CLDMV/.github#351 (CLDMV/.github#350).
cldmv-bot
Bot
added
! release → master
Contributor
Author
🔒 Dependency Review
|
Contributor
Author
📦 Bundle size unchanged
📊 Generated by |
Bumps the patch group with 1 update in the / directory: [@cldmv/eslint-plugin-jsonv](https://github.com/CLDMV/jsonv-eslint-plugin-jsonv). Updates `@cldmv/eslint-plugin-jsonv` from 1.0.10 to 1.0.13 - [Release notes](https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/releases) - [Commits](CLDMV/jsonv-eslint-plugin-jsonv@v1.0.10...v1.0.13) --- updated-dependencies: - dependency-name: "@cldmv/eslint-plugin-jsonv" dependency-version: 1.0.13 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tch group across 1 directory (#76) Bumps the patch group with 1 update in the / directory: [@cldmv/eslint-plugin-jsonv](https://github.com/CLDMV/jsonv-eslint-plugin-jsonv). Updates `@cldmv/eslint-plugin-jsonv` from 1.0.10 to 1.0.13 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/releases">@cldmv/eslint-plugin-jsonv's releases</a>.</em></p> <blockquote> <h2>v1.0.13</h2> <p>release: v1.0.13 - publish real types for the plugin, language and AST</p> <h1><code>@cldmv/eslint-plugin-jsonv</code> v1.0.13 Changelog</h1> <p><strong>Release Date</strong>: September 2026 <strong>Release Type</strong>: Patch <strong>Branch</strong>: <code>release/1.0.13</code></p> <hr /> <h2>Overview</h2> <p>Version 1.0.13 makes the plugin's published types real. <code>dist/index.d.mts</code> used to declare the default export as a bare <code>Object</code>; it now types the plugin, the <code>jsonv/jsonv</code> language, <code>JsonvSourceCode</code>, and every AST node against <code>@eslint/core</code>'s generics, and the JSDoc that generates those declarations is now type-checked in CI. The release also closes a gap the new types surfaced: <code>engines.node</code> and a missing <code>eslint</code> peer range now match what the plugin's runtime dependencies actually require. Alongside that, the plugin accepts three more <code>@cldmv/jsonv</code> language options, and the repository adopts the CLDMV lint/format tooling.</p> <p>No configuration changes are required to pick this up — existing <code>eslint.config.mjs</code> files, rules, and <code>languageOptions</code> keep working unchanged.</p> <hr /> <h2>🐛 Bug Fixes</h2> <h3>Published types describe a real ESLint plugin (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/30">#30</a>, fixes <a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/28">#28</a>)</h3> <p><code>dist/index.d.mts</code> declared <code>const plugin: Object</code>, so a TypeScript (or <code>// @ts-check</code>) config got no type for <code>plugin.configs.recommended</code>, <code>plugin.languages.jsonv</code>, or <code>languageOptions</code>, and nothing for a rule author to use for the AST node types the language exposes. The JSDoc in <code>index.mjs</code> is now typed against <code>@eslint/core</code>'s <code>Language</code>, <code>TextSourceCode</code>, <code>OkParseResult</code>, and <code>Plugin</code> generics, the way <code>@eslint/json</code> types its JSON language, and <code>tsconfig.types.json</code> now type-checks it (<code>checkJs: true</code>) instead of only emitting from it. The package exports typedefs for every AST node (<code>JsonvProgram</code>, <code>JsonvObjectExpression</code>, <code>JsonvProperty</code>, <code>JsonvLiteral</code>, <code>JsonvIdentifier</code>, <code>JsonvMemberExpression</code>, <code>JsonvTemplateLiteral</code>, <code>JsonvTemplateElement</code>), for <code>JsonvLanguageOptions</code>, and for a rule's visitor (<code>JsonvRuleDefinition</code>, <code>JsonvRuleVisitor</code>), plus the <code>JsonvSourceCode</code> class itself, and <code>JsonvSourceCode</code> is now a named export alongside the default plugin. A new <code>test:types</code> script compiles a type-level consumer test against the built declarations the way an <code>eslint.config.mts</code> would, and <code>build:ci</code> runs it.</p> <h3>The declared Node floor and ESLint range match what the plugin needs (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/37">#37</a>, fixes <a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/32">#32</a>)</h3> <p><code>engines.node</code> still said <code>>=18.0.0</code>, but the runtime dependencies added for real types — <code>@eslint/core</code> and <code>@eslint/plugin-kit</code> — both require <code>^20.19.0 || ^22.13.0 || >=24</code>, and so does ESLint 10 itself. Installing on Node 18 could fail or warn while <code>engines</code> claimed support. <code>engines.node</code> now states that real floor, and a new <code>eslint</code> peer dependency (<code>^9.13.0 || ^10.0.0</code>) tells consumers which ESLint versions the plugin's <code>languages</code> API needs — <code>^9.13.0</code> is the first release with <code>defaultLanguageOptions</code> support for plugin languages.</p> <h3><code>mode</code>, <code>strictOctal</code>, and <code>allowInternalReferences</code> language options (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/39">#39</a>, fixes <a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/34">#34</a>)</h3> <p>The README documented a <code>mode</code> option, and the plugin rejected it (<code>Unknown language option "mode"</code>) because it was never actually forwarded to the parser. <code>mode</code> (<code>"jsonv"</code>, <code>"json5"</code>, or <code>"json"</code>, default <code>"jsonv"</code>), <code>strictOctal</code> (boolean, default <code>false</code>), and <code>allowInternalReferences</code> (boolean, default <code>true</code>) are now accepted, validated, and passed through to both <code>parseWithOptions()</code> and <code>parseToAst()</code>, matching <code>@cldmv/jsonv</code>'s own <code>ParseOptions</code>. <code>reviver</code>, <code>preserveComments</code>, and <code>tolerant</code> stay unsupported, and <code>validateLanguageOptions</code> now names the reason when one of those three is set instead of reporting it as merely unknown. The README's <strong>Configuration Options</strong> table documents all five options with their defaults, and a new test extracts the README's own <code>languageOptions</code> examples and runs them through <code>validateLanguageOptions</code> and a live <code>Linter</code>, so the docs and the code can't drift apart again.</p> <h2>🔧 CI & tooling</h2> <ul> <li>The CLDMV eslint + prettier config, <code>lint</code> / <code>lint:fix</code> / <code>format</code> / <code>format:check</code> scripts, and the <code>.githooks</code> pre-commit hook are added, and the existing sources and README are reformatted repo-wide (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/38">#38</a>, fixes <a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/33">#33</a>).</li> <li><code>release-merge</code> is re-armed on every check-producing workflow, instead of only the ones that existed when it was first wired (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/40">#40</a>).</li> <li>The v4 workflows are synced with the <code>CLDMV/.github</code> v4.29.2 templates (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/42">#42</a>).</li> <li>The bundle-size workflow is added, and the <code>release-merge</code> required-workflow list is restored to the full set (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/43">#43</a>).</li> </ul> <h2>📚 Documentation</h2> <ul> <li><strong>NEW:</strong> <a href="https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/blob/HEAD/v1.0.13.md">docs/changelog/v1/v1.0.13.md</a> — this changelog.</li> <li>README <strong>Installation</strong> now states the Node and ESLint requirements (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/37">#37</a>).</li> <li>README <strong>Configuration Options</strong> documents <code>mode</code>, <code>strictOctal</code>, and <code>allowInternalReferences</code> alongside <code>year</code> and <code>strictBigInt</code> (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/39">#39</a>).</li> </ul> <h2>🔧 Dependencies</h2> <ul> <li><strong>NEW</strong> runtime dependency: <code>@eslint/core</code> <code>^1.2.1</code>, which provides the <code>Language</code>, <code>TextSourceCode</code>, and <code>Plugin</code> types the published declarations are built against (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/30">#30</a>).</li> <li><strong>NEW</strong> dev dependency: <code>@types/node</code> <code>^26.6.3</code>, needed by the type-checked JSDoc (<a href="https://redirect.github.com/CLDMV/jsonv-eslint-plugin-jsonv/issues/30">#30</a>).</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/commit/2ce4e13d4b9ffeb4e0d86388f0b00604bed56672"><code>2ce4e13</code></a> release: v1.0.13 - publish real types for the plugin, language and AST</li> <li><a href="https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/commit/2686e4f7bfde1ba8d73080836e15b1d5887a1767"><code>2686e4f</code></a> release: v1.0.12 - build a real ESLint AST from the jsonv parser</li> <li><a href="https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/commit/55c0ec8df0925543aa2bbb6f59bbc849363ade69"><code>55c0ec8</code></a> release: v1.0.11 - validate language options and clean up the language…</li> <li>See full diff in <a href="https://github.com/CLDMV/jsonv-eslint-plugin-jsonv/compare/v1.0.10...v1.0.13">compare view</a></li> </ul> </details> <details> <summary>Install script changes</summary> <p>This version adds <code>prepare</code> script that runs during installation. Review the package contents before updating.</p> </details> <br />
Shinrai
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What's Changed
💥 Breaking Changes
No breaking changes
✨ Features
No new features
🐛 Bug Fixes
No bug fixes
📦 Dependencies
🔧 Other Changes
👥 Contributors
Avg: 98.7% ·
47d2ad9· Node lts/*Co-authored-by: Shinrai Shinrai@users.noreply.github.com