-
-
Notifications
You must be signed in to change notification settings - Fork 0
Non-numeric priority keys are silently dropped #54
Copy link
Copy link
Closed
Labels
area: coreTouches core library / runtime source codeTouches core library / runtime source codepriority: lowMinor issue or improvement that can be deferred without impactMinor issue or improvement that can be deferred without impactstatus: implementedBuilt and deployed, but not yet fully tested/verifiedBuilt and deployed, but not yet fully tested/verifiedtype: bugSomething is broken or not behaving as expectedSomething is broken or not behaving as expected
Description
Activity
Metadata
Metadata
Assignees
Labels
area: coreTouches core library / runtime source codeTouches core library / runtime source codepriority: lowMinor issue or improvement that can be deferred without impactMinor issue or improvement that can be deferred without impactstatus: implementedBuilt and deployed, but not yet fully tested/verifiedBuilt and deployed, but not yet fully tested/verifiedtype: bugSomething is broken or not behaving as expectedSomething is broken or not behaving as expected
Problem
The constructor runs
prioritieskeys throughparseInt, so a config likepriorities: { high: { postDelay: 100 } }is dropped with no warning. The README's alias example had this mistake (fixed in #50), which shows how easy it is to hit.Fix
Warn on keys that aren't integers, using the same deprecation/warning event mechanism or a thrown
TypeError, so a typo can't silently disable a priority config. Add a test.