fix(discovery): never walk dependency folders, at any depth - #126
Merged
Merged
Conversation
cldmv-bot
Bot
added
! fix → next
Discovery skipped only .git by name, so a project without a .gitignore (or a sub-package with its own node_modules, or a tracked dependency folder, or gitignore: false) had headers stamped into installed packages. Dependency folders are now never walked, at any depth and whatever the ignore files say: node_modules, bower_components, jspm_packages, .pnpm-store and .yarn, plus a vendor folder that holds Composer's autoload.php or Go's modules.txt. Other folders named vendor are still processed, since the name is also used for code a project maintains itself (front-end vendor/ scripts, Laravel's resources/views/vendor). A path inside a dependency folder that is named explicitly, through includeFolders / --include-folder or input / --input, is still processed. Build output (dist, build, coverage, ...) keeps being processed unless an ignore file or excludeFolders says otherwise. Tests from #71 that expected node_modules to be walked are updated to the new rule. Fixes #123
Shinrai
force-pushed
the
fix/ignore-dependency-folders
branch
from
October 4, 2026 00:41
523cd89 to
adb3d7c
Compare
Shinrai
added a commit
that referenced
this pull request
Oct 4, 2026
The non-JS file, repeatable --input and dependency-folder fixes land in the same release as #117. Describe each fix, the reported skips, and the behaviour changes an existing setup could notice.
Shinrai
previously approved these changes
Oct 4, 2026
cldmv-bot
Bot
dismissed
Shinrai’s stale review
October 4, 2026 01:21
The merge-base changed after approval.
Shinrai
enabled auto-merge
October 4, 2026 01:22
Shinrai
approved these changes
Oct 4, 2026
Shinrai
added a commit
that referenced
this pull request
Oct 4, 2026
…#121) ## 🚀 What's Changed ### 💥 Breaking Changes _No breaking changes_ ### ✨ Features _No new features_ ### 🐛 Bug Fixes - fix(discovery): never walk dependency folders, at any depth (#121) (adb3d7c) - fix(cli): process every --input value instead of only the last (#121) (be9b89b) - fix: never write a comment into files that cannot carry one; force-only Markdown headers (#121) (082977f) ### 📦 Dependencies _No dependency updates_ ### 🔧 Other Changes - docs: cover #124, #125 and #126 in the v2.1.4 notes and What's New (#121) (13c8859) - docs: add the v2.1.4 changelog and restructure the README (#121) (0358f40) - docs(changelog): backfill changelogs for v1.0.0–v1.3.12, v2.1.1 and v2.1.2 (#121) (caa7c1e) <details> <summary>👥 Contributors</summary> - @Shinrai </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What's Changed
💥 Breaking Changes
No breaking changes
✨ Features
No new features
🐛 Bug Fixes
📦 Dependencies
No dependency updates
🔧 Other Changes
No other changes
👥 Contributors