Skip to content

ci: stop the skipped PR-run mirror from satisfying Required PR Check #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shinrai merged 1 commit into from
Oct 2, 2026
Merged

ci: stop the skipped PR-run mirror from satisfying Required PR Check #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,16 +310,30 @@ jobs:
# automatically — no `pull_request` round-trip needed for non-fork
# non-release PRs.
required-check:
name: ✅ Required PR Check
# The name is conditional on purpose. On an in-repo feature PR the
# `pull_request` run skips this job (the push run owns the status), and
# a skipped job still posts a check run under its name. GitHub treats a
# SKIPPED required check as satisfied — so if the skipped job were named
# `✅ Required PR Check`, it would green-light the ruleset (and enable
# auto-merge) while the push run's real mirror hadn't been created yet
# (it only appears once `ci` finishes), letting a PR merge mid-test or
# even override a red result. An expression name keeps the skipped job
# off the required name: GitHub does not evaluate the name of a skipped
# job, so it shows up as the raw expression text (still not the
# required name), while every path that runs evaluates to
# `✅ Required PR Check`. The condition is written out anyway so the
# name stays correct if GitHub ever starts evaluating it, and must stay
# identical to the `if:` below.
name: ${{ (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == true || github.event.pull_request.head.ref == 'next' || github.event.pull_request.head.ref == 'hotfixes') && '✅ Required PR Check' || '⏭️ Required PR Check (reported by the push run)' }}
needs: ci
# Mirror the `ci` job's gating exactly. The four cases that run:
# 1. push events (job needs CI run)
# 2. fork PRs (push doesn't cover forks)
# 3. release PRs from `next` → master/main (push covers SHA but commit-gate skips chore-bump)
# 4. release PRs from `hotfixes` → master/main (same reason)
# In-repo feature PRs targeting `next` / `hotfixes` skip on
# pull_request — push on the head branch already posted the status
# on the SHA, and mirroring here would overwrite it.
# pull_request — the push run on the head branch reports the status
# on the SHA. See the `name:` above for why the skipped job is renamed.
if: |
always() && (
github.event_name != 'pull_request' ||
Expand Down
Loading