Validation-branch coverage, services tests, control-parity sweep, freshness lane (punch-list 6, 9) - #4
Merged
Conversation
… report decision boundaries
…ontrol parity sweep)
…es the remediation; DNC score test gains its positive control
NaN in the float64 qualified_hiring_need column is truthy, so the 'or 0' idiom at pages.py:347 and services.py:126 did not guard it and int(NaN) raised ValueError. Both sites now use the pd.isna idiom already established at services.py:94; the deliberate None branch keeps working (pd.isna covers both). Regression test drives None and NaN through the real forecast-frame path for both the page render and the leadership summary. Suite: 59 passed. Co-Authored-By: GPT 5.6 Sol <noreply@openai.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JBGunVuQranA9dUGqxGuBD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What shipped
validate_demo_dataerror branch now exercised (16 mutators + thin-history warning); first tests for services.py (Do-Not-Contact exclusion with positive control, draft safety, report decision boundaries); the Trust-controls section of ARCHITECTURE.md is now machine-checked against named tests — including a guard that flags any UNANNOTATED bullet.Process
PM-briefed SME plans, Fable plan review, GPT 5.6 Sol implementation, adversarial QC + verified findings, supervised fixes. Gate green at every commit: ruff + pytest + validate_demo_data.