ROCC "Now" roadmap + Top-10 polish - #1
Merged
Merged
Conversation
…el map Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
…gend Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
… floor Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
…+ coverage captions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
…Hq=Hd Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
… pending) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
…t test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
…alth Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
Every other CI/dev dependency is exact-pinned (ruff==0.15.22, pytest==8.4.1, requirements.txt). Pin pip-audit==2.10.1 (resolved current stable) too, for consistency and a smaller supply-chain surface, even though the step is advisory (continue-on-error) and runs with contents:read only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the review's entire "Now" roadmap and all ten Top-10 recommendations as a cluster of small, low-risk, presentation-and-content fixes — converting ROCC's two weakest reviewed dimensions (Usability 5.5, Visual polish 6.0) into strengths without touching the analytical/governance core, the synthetic data generator's values, or the aggregates-by-design boundary.
Highlights:
COLUMN_LABELSmap: no rawsnake_caseDB headers on any leadership table (Outreach queue, Site Readiness, Resource Network + 4 detail tabs, Source Performance, Ratio Forecast, Privacy inventory)html.escapeon the one unescapedunsafe_allow_htmlinterpolationgatherUsageStats = false)rufflint gate (pyflakes + syntax) wired into CI; 7 dead-code items removedpip-auditscan (pinned, non-blocking) + container boot/health proberun_demo.ps1) aligned to runtime-only dependenciesScope: 20 tasks (S0–S19) executed in order per a supervisor-reviewed one-shot plan, plus one post-review security fix (pinned an unpinned
pip-auditinstall in the advisory CI step). 21 commits total. Test suite grew from 20 to 23 tests;pytest -q,validate_demo_data.py, andruff check .are green locally after every commit. Byte-stability of the synthetic generator was proven unchanged (SHA-256 fingerprints of all 11 data frames matchmainbefore and after the one permittedsynthetic.pyedit, a dead-code deletion).An adversarial QC + security review ran against the full branch before this PR was opened; the one confirmed finding (unpinned
pip-auditversion in CI) was fixed in a follow-up commit.Does not merge itself — merge to
mainis an owner decision. The container-boot CI step (S18) could not be verified locally (no Docker on the build box); it needs to be confirmed green on this PR's own CI run.Test plan
pytest -q— 23 passed (local)python scripts/validate_demo_data.py— exit 0 (local)ruff check .— all checks passed (local)docker build+ container boot/health probe — unverified locally, no Docker on the build box)🤖 Generated with Claude Code
https://claude.ai/code/session_01EUwLDdWYTGrWQwqb94VGCk