Project 4: Grace Gilbert#4
Open
gracelgilbert wants to merge 29 commits into
Open
Conversation
gracelgilbert
commented
Oct 9, 2019
- Repo Link
- Features
- Vulkan grass and compute pipeline setup
- Grass tessellation and rendering
- Physics simulation on blades
- Gravity
- Recovery
- Wind (noise, sinusoidal, radial)
- Culling
- Orientation
- Frustum
- Distance
- Performance Analysis
- I think a little bit more background on the Vulkan pipeline would have helped me through some of the setup stages. I struggled to figure out the inputs and outputs of the compute and tessellation shaders, so discussing these in a application oriented way may have helped. I also think it would have helped to connect the base code to the Vulkan pipeline a little more, pointing out which parts of the base code are performing which parts of the pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.