Repository navigation
printer cbor BUGFIX double free when printing opaque lists - #2601
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cbor_print_opaq()generates the member name of an opaque list/leaf-list on the first instance and frees it twice when that instance is also the last one (ASan: double-free), while with several instances the name is already gone when the array is completed so the whole list is silently dropped from the output; any data holding an unknown list inside anydata (e.g.{"cbor-test:anydata-payload":{"foo:bar":[{"x":"y"}]}}parsed with default options) or parsed withLYD_PARSE_OPAQtriggers it when printed as CBOR, so generate the name once the array is completed likecbor_print_leaf_list()does, andtest_opaque_listcovers both cases.