Repository navigation
ssh: fix support for system-managed users - #650
Merged
Merged
Conversation
It looks like commit eb8fabc accidentally swapped `LY_ENOT` (which says "this feature is valid, but not enabled") for `LY_ENOTFOUND` (which says "the YANG model does not even define this feature"). As a result, support for using system users was unconditionally disabled. Fixes: eb8fabc session server ssh UPDATE migrate to callback-based auth for libssh 0.12+ Co-authored-by: Tomáš Pecka <tomas.pecka@cesnet.cz> Reported-by: Michal Hažlinský <hazlinsky@cesnet.cz>
michalvasko
approved these changes
Oct 19, 2026
Member
|
Thanks. Not that simple to test a feature dependent on the system configuration but we will think about it. |
michalvasko
pushed a commit
that referenced
this pull request
Oct 19, 2026
No test disabled the local-users-supported feature, so the system users authentication paths were never exercised, letting the feature check regression fixed in #650 slip through. Add test_system_users covering publickey (token-free authorized_keys path) and password (mocked getpwnam_r) authentication of system users and extend test_pam with a keyboard-interactive system users case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like commit eb8fabc accidentally swapped
LY_ENOT(which says "this feature is valid, but not enabled") forLY_ENOTFOUND(which says "the YANG model does not even define this feature"). As a result, support for using system users was unconditionally disabled.Please consider adding some unit tests for this; it's a core feature for us, and it is not ideal that a regression like this slipped through a huge refactoring commit. We're using
pam_wrapperin rousette for this purpose.Fixes: eb8fabc session server ssh UPDATE migrate to callback-based auth for libssh 0.12+
Reported-by: Michal Hažlinský hazlinsky@cesnet.cz