Skip to content

Update unbacked execution for accuracy/tracking#588

Open
kevross33 wants to merge 1 commit into
CAPESandbox:masterfrom
kevross33:patch-895278
Open

Update unbacked execution for accuracy/tracking#588
kevross33 wants to merge 1 commit into
CAPESandbox:masterfrom
kevross33:patch-895278

Conversation

@kevross33
Copy link
Copy Markdown
Contributor

Improve process tracking and of memory frees

Improve process tracking and of memory frees
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several Windows memory signatures to improve unbacked memory tracking by handling deallocations via NtFreeVirtualMemory and VirtualFree. However, a critical bug was identified across all modified signatures: the hProcess argument of VirtualAllocEx is treated as a Process ID (PID) rather than a process handle. This causes unbacked memory ranges to be stored under the handle value instead of the target process's actual PID, breaking remote allocation detection. The reviewer provided suggestions to resolve this by limiting tracking to self-allocations where hProcess represents the current process.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Comment thread modules/signatures/windows/memory_unbacked_execution.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant