boards: add support for usbcan_iso, usbcanfd solo/dual,canbridge_g473 - #219
Open
AlekseyMamontov wants to merge 1 commit into
Open
boards: add support for usbcan_iso, usbcanfd solo/dual,canbridge_g473#219AlekseyMamontov wants to merge 1 commit into
AlekseyMamontov wants to merge 1 commit into
Conversation
henrikbrixandersen
requested changes
Jul 28, 2026
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
Member
There was a problem hiding this comment.
Please address the review comments below and split into three commits, one for each board.
| @@ -0,0 +1,6 @@ | |||
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |||
Member
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| # SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
| @@ -0,0 +1,39 @@ | |||
| /* | |||
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| * SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
Comment on lines
+1
to
+2
| # Copyright (c) 2024-2025 Henrik Brix Andersen <henrik@brixandersen.dk> | ||
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
Member
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2024-2025 Henrik Brix Andersen <henrik@brixandersen.dk> | |
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| # SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
Comment on lines
+1
to
+2
| /* | ||
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
Member
There was a problem hiding this comment.
Suggested change
| /* | |
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| /* | |
| * SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
| @@ -0,0 +1,6 @@ | |||
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |||
Member
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| # SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
| @@ -0,0 +1,33 @@ | |||
| /* | |||
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| * SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
| can-controller = <&fdcan1>; | ||
| activity-leds = <&led_rx &led_tx>; | ||
| }; | ||
| channel1 { |
| @@ -0,0 +1,6 @@ | |||
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |||
Member
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| # SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
| @@ -0,0 +1,28 @@ | |||
| /* | |||
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |||
Member
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> | |
| * SPDX-FileCopyrightText: Copyright (c) 2026 Oleksii Mamontov <mamontov1@gmail.com> |
Member
There was a problem hiding this comment.
Please remove this change.
Author
|
Hello Brix, thanks for the review! )) |
… and boot animation Signed-off-by: Oleksii <35818127+AlekseyMamontov@users.noreply.github.com>
AlekseyMamontov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Brix, @henrikbrixandersen ,
This pull request adds support for the following hardware targets:
usbcan_iso (STM32F072XB)
usbcanfd_solo (STM32G431XX)
usbcanfd_dual and canbridge_g473 (STM32G473XX)
Signed-off-by: Oleksii Mamontov mamontov1@gmail.com