fix: align contributor pnpm requirement with CI - #153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the root engine requirement, README and CONTRIBUTING. Explain how to use
npx pnpm@10.18.3when the global version differs.Fixes #130.
Evidence
ERR_PNPM_IGNORED_BUILDSfor esbuild.After: The engine requirement rejects pnpm 11 early; pinned pnpm 10.18.3 installs successfully. The local version comparison was verified during preparation.
pnpm check,pnpm test, andpnpm pack:dry-runpassed with pnpm 10.18.3.Merge Danger
Door: Two-way. Revert the requirement and documentation together.
Blast Radius: Contributors. Developers must use the pinned pnpm version; published package behavior is unchanged.
Release decision: No release needed. Only the private workspace and contributor docs change; no published packages, changeset, version bump, or release commands are required.