fix(examples): support Python CLI invocation on Windows - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python batch runner could find
calle.cmdduring its precheck but still launch barecalle, causing WinError 2 on Windows. Use one executable resolver for prechecks, CLI launch, and npm installation. Preserve explicit relative paths and Windows backslashes, and report missing or non-executable commands clearly.Add Windows/Python troubleshooting and invocation guidance, linked from the CLI install guide, example index, and batch runner README. Keep direct MCP examples distinct from CLI integrations. Refs CALLE-AI/awesome-phone-call-agents#788.
Evidence
calle --helpfails from Python whilecalle.cmd --helpsucceeds. The batch runner discarded its resolved path and parsed Windows paths using POSIX escaping..cmdlaunch, and the documented Node launcher example. CI runs command tests on Windows and batch-runner tests on Linux..cmdlaunch, and the documented Python launcher example.Merge Danger
Door: Two-way. Revert the example and documentation changes if needed.
Blast Radius: Examples. Batch-runner command launching changes; CLI runtime and public APIs remain unchanged. No package release or changeset is needed because the example is not packaged.