Repository navigation
US1216212: Default to UseJvmDefault when FIPS is detected - #26
Closed
anshuman0799 wants to merge 2 commits into
Closed
anshuman0799 wants to merge 2 commits into
anshuman0799 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The public API break and fail-open FIPS detection could cause compatibility and compliance failures.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds FIPS-aware TLS provider selection so default policies avoid non-certified PQC providers.
Changes:
- Detects Linux FIPS mode and defaults to JVM providers.
- Adds policy tests and consolidated documentation.
- Advances modules to version 2.1.0.
| File | Description |
|---|---|
release-notes-2.1.0.md |
Documents FIPS behavior. |
release-notes-2.0.2.md |
Removes obsolete release template. |
README.md |
Consolidates provider-policy guidance. |
pom.xml |
Updates parent project version. |
caf-ssl-core/pom.xml |
Updates core parent version. |
caf-ssl-dropwizard/pom.xml |
Updates Dropwizard parent version. |
caf-ssl-spring/pom.xml |
Updates Spring parent version. |
caf-ssl-core/src/main/java/com/github/cafapi/ssl/core/SslProviderConfigurator.java |
Implements FIPS detection and policy resolution. |
caf-ssl-core/src/test/java/com/github/cafapi/ssl/core/SslProviderConfiguratorTest.java |
Tests FIPS policy decisions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+148
to
+149
| public static boolean shouldUseBouncyCastle(final String policy, final boolean runtimePqcSupported, | ||
| final boolean fipsEnabled) |
Comment on lines
+103
to
+107
| @Test | ||
| void isFipsEnabledNeverThrows() | ||
| { | ||
| // Fail-safe contract: probing for FIPS mode must never abort startup. | ||
| SslProviderConfigurator.isFipsEnabled(); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=1216212