Pull bug fix from main to dev#33
Merged
Merged
Conversation
fix(karma): isolate per-tab state to prevent cross-tab UI corruption and crashes - Implement save_globals_to_tab_context() to save all Karma globals (UI pointers, probe data, sniffer state) into tab context on tab switch - Implement restore_tab_context_to_globals() to restore Karma state from context when switching back to a tab - Extend restore_ui_pointers_from_ctx() with all Karma widget pointers - Mirror widget pointers into ctx immediately after page creation so save/restore works correctly from the first tab switch - Restore karma_probes_container and button pointers in show_karma_page() when returning to an existing page (was causing probe list to render into the wrong tab's container → blank list / crash) - Move karma state reset (probe_count, selected_idx) to new-page creation only; returning to an existing page no longer clears collected probes - Flush UART RX buffer before sending list_probes to discard leftover sniffer output that was filling the 2048-byte response buffer and truncating the actual probe list - Auto-fetch and display probes on Stop Sniffer button press; remove the now-redundant Show Probes button from the UI
Version check was using strict string equality, so any firmware newer than the required version (e.g. 1.6.4 when 1.6.3 is required) was incorrectly flagged as a mismatch and showed a warning popup. Replace strcmp with a semver-aware comparison that only marks the firmware as mismatched when it is strictly older than the minimum required version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.