Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/converters/imagemagick.ts
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,10 @@ export function convert(
outputArgs.push("-background", "white", "-alpha", "remove");
}

// Apply EXIF orientation so photos (e.g. from phones) don't end up sideways
// when converted to formats where the orientation tag is lost or ignored
outputArgs.push("-auto-orient");

return new Promise((resolve, reject) => {
execFile(
"magick",
Expand Down
16 changes: 16 additions & 0 deletions tests/converters/imagemagick.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,19 @@ test("convert respects emf as input filetype", async () => {
);
expect(loggedMessage).toBe("stdout: Fake stdout");
});

test("convert applies EXIF auto-orient", async () => {
const mockExecFile: ExecFileFn = (
_cmd: string,
_args: string[],
callback: (err: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
calls.push(_args);
callback(null, "", "");
};

const result = await convert("input.jpg", "jpg", "png", "output.png", undefined, mockExecFile);

expect(result).toBe("Done");
expect(calls[0]).toEqual(expect.arrayContaining(["input.jpg", "-auto-orient", "output.png"]));
});
Loading