Add check for abstract classes in analyzer rule SGF1001 - #71
Merged
Merged
Conversation
Skip attribute check for abstract classes in RequireSfgGeneratorAttributeRule. Fixes ByronMayne#70
Owner
|
The change makes sense to me! |
Owner
|
and I am blind, I though the warning in the commit was just a ai analyzer error. There is currently a compiler error |
Contributor
Author
Me too :D I edited through GitHub online interface and did not compile locally - I should have said so in the PR description, apologies! I thought that copying from the other analyzer rule would be OK ... |
pjanck
added a commit
to pjanck/SourceGenerator.Foundations
that referenced
this pull request
Jul 14, 2026
Fixing the incomplete ByronMayne#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip attribute check for abstract classes in RequireSfgGeneratorAttributeRule.
Fixes #70