Fix guard against null field values and ACF component mismatches - #61
Open
manuel-be-one wants to merge 1 commit into
Open
Fix guard against null field values and ACF component mismatches#61manuel-be-one wants to merge 1 commit into
manuel-be-one wants to merge 1 commit into
Conversation
Adds defensive checks to prevent PHP errors such as undefined offsets, empty variable access, and array_combine mismatches in sync-related classes, improving overall robustness.
manuel-be-one
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
💡 What does this PR do?
$field_valueemptiness before accessing$field_value[0]->labelin theotherOptionpath of radio/checkbox fields (base.php, also falls back to$option->optionIdiflabelis not setarray_combine()inset_acf_field_value()(push.php): skip rows where$componentFieldsKeyscount does not match the ACF group values count, and log the mismatch instead of throwing a fatal error❓ Why are we doing this?
otherOption,$field_valuecan be null, causing aTypeErroron$field_value[0]->labelthat silently killed the sync.array_combine()with mismatched arrays throws aValueErrorand leaves the item stuck in an "in progress" push state with a 500 error.